Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

layout computation: gracefully handle unsized types in unexpected locations #129970

Merged
merged 4 commits into from
Sep 17, 2024
Merged

layout computation: gracefully handle unsized types in unexpected locations #129970

merged 4 commits into from
Sep 17, 2024

Commits on Sep 16, 2024

  1. make LayoutCx not generic

    Lukas Markeffsky committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    16be666 View commit details
    Browse the repository at this point in the history

  2. layout computation: eagerly error for unexpected unsized fields

    Lukas Markeffsky committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    6974501 View commit details
    Browse the repository at this point in the history

  3. assert that unexpectedly unsized fields are sized in the param env

    Lukas Markeffsky committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    3db930a View commit details
    Browse the repository at this point in the history

  4. get rid of an old hack 

    For structs that cannot be unsized, the layout algorithm sometimes moves
unsized fields to the end of the struct, which circumvented the error
for unexpected unsized fields and returned an unsized layout anyway.

This commit makes it so that the unexpected unsized error is always
returned for structs that cannot be unsized, allowing us to remove an
old hack and fixing some old ICE.
    Lukas Markeffsky committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    20d2414 View commit details
    Browse the repository at this point in the history