Rolling up some more PRs #13006
Closed
Rolling up some more PRs #13006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is adequate because when a function has a type that isn't caught here,
that is, it has a single argument, but it *isn't* `&mut BenchHarness`, it
errors later on with:
error: mismatched types: expected `fn(&mut test::BenchHarness)` but found
`fn(int)` (expected &-ptr but found int)
which I consider acceptable.
Closes rust-lang#12997
This takes the time for `rustc libstd/lib.rs -Z ast-json-noexpand > file.json` from 9.0s to 3.5s (~0.5s spent parsing etc.) and `-Z ast-json` from 11s to 5s (~1.5s spent parsing and expanding).
The pretty printer constitues an enormous amount of code, there's no reason for it to be generic. This just least to a huge amount of metadata which isn't necessary. Instead, this change migrates the pretty printer to using a trait object instead. Closes rust-lang#12985
Tweak the definition of `char` to use the appropriate Unicode terminology.
Move syntax-extension-hexfloat.rs to run-pass-fulldeps so it depends on libhexfloat being compiled before running.
It appears that the --as-needed flag to linkers will not pull in a dynamic library unless it satisfies a non weak undefined symbol. The linkage1 test was creating a dynamic library where it was only used for a weak-symbol as part of an executable, so the dynamic library was getting discarded. This commit adds another symbol to the library which satisfies a strong undefined symbol, so the library is pulled in to resolve the weak reference.
Remove the linker_private and linker_private_weak linkage attributes, they have been superseded by private and private_weak and have been removed in upstream LLVM in commit r203866.
Remove obsolete linkage types from the llvm::Linkage enum. The linkage types are no-ops and weren't used inside rustc anyway.
… numeric type serialize: ref rust-lang#12697 minor adj. to last char check + prettyencode test
A major discoverability issue with rustdoc is that all crates have their documentation built in isolation, so it's difficult when looking at the documentation for libstd to learn that there's a libcollections crate with a HashMap in it. This commit moves rustdoc a little closer to improving the multiple crate experience. This unifies all search indexes for all crates into one file so all pages share the same search index. This allows searching to work across crates in the same documentation directory (as the standard distribution is currently built). This strategy involves updating a shared file amongst many rustdoc processes, so I implemented a simple file locking API for handling synchronization for updates to the shared files. cc rust-lang#12554
possible by also calling `clone_from` on it. In general, `Clone` implementors that overwrite `clone_from` should try to to use it recursivly for substructures.
bors
added a commit
that referenced
this pull request
Mar 19, 2014
Closes #13008 (Made the `clone_from` implementation for `~T` reuse the `T` itself if possible) Closes #13003 (Make method Vec::remove() public) Closes #13002 (disallow duplicate methods in trait impls) Closes #13000 (rustc: test: don't silently ignore bad benches) Closes #12999 (rustc: buffer the output writer for -Z ast-json[-noexpand].) Closes #12993 (syntax: Don't parameterize the the pretty printer) Closes #12990 (`char` reference: s/character/Unicode scalar value/) Closes #12987 (Move syntax-extension-hexfloat.rs) Closes #12983 (Fix linkage1 test which fails due to --as-needed) Closes #12978 (rustc: remove linker_private/linker_private_weak) Closes #12976 (libsyntax: librustdoc: ignore utf-8 BOM in .rs files) Closes #12973 (closes #12967 fix [en|de]coding of HashMap<K,V> where K is a numeric type) Closes #12972 (Add impl IntoStr for ::std::vec_ng::Vec<Ascii>) Closes #12968 (deny missing docs getopts) Closes #12965 (Documentation and formatting changes for option.rs.) Closes #12962 (Relax the memory ordering on the implementation of UnsafeArc) Closes #12958 (Typo fixes.) Closes #12950 (Docsprint: Document ops module, primarily Deref.) Closes #12946 (rustdoc: Implement cross-crate searching)
|
+10000 for cross-crate searching!! |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 11, 2024
…, r=Jarcho Add error message to manual_inspect lint r? `@Jarcho` changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13008 (Made the
clone_fromimplementation for~Treuse theTitself if possible)Closes #13003 (Make method Vec::remove() public)
Closes #13002 (disallow duplicate methods in trait impls)
Closes #13000 (rustc: test: don't silently ignore bad benches)
Closes #12999 (rustc: buffer the output writer for -Z ast-json[-noexpand].)
Closes #12993 (syntax: Don't parameterize the the pretty printer)
Closes #12990 (
charreference: s/character/Unicode scalar value/)Closes #12987 (Move syntax-extension-hexfloat.rs)
Closes #12983 (Fix linkage1 test which fails due to --as-needed)
Closes #12978 (rustc: remove linker_private/linker_private_weak)
Closes #12976 (libsyntax: librustdoc: ignore utf-8 BOM in .rs files)
Closes #12973 (closes #12967 fix [en|de]coding of HashMap<K,V> where K is a numeric type)
Closes #12972 (Add impl IntoStr for ::std::vec_ng::Vec)
Closes #12968 (deny missing docs getopts)
Closes #12965 (Documentation and formatting changes for option.rs.)
Closes #12962 (Relax the memory ordering on the implementation of UnsafeArc)
Closes #12958 (Typo fixes.)
Closes #12950 (Docsprint: Document ops module, primarily Deref.)
Closes #12946 (rustdoc: Implement cross-crate searching)