Improve the Vec experience #13020
Closed
Improve the Vec experience #13020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any crates that don't have |
|
They should have deny, IMO. |
|
I think stage1+ has -D warnings or whatever the -Werror equivalent is. |
|
This is not a case of regression. We have 26 crates, 24 of which have I think that that statistic shows that this is not a useful lint at this time. I'm explicitly not removing it because it will be very useful as soon as the standard libraries are ported. |
This is an incredibly common type, and it is expected to be used in many many places. This type should be in the prelude.
Most of the standard distribution is still using ~[] instead of Vec, so this lint is essentially useless currently. When the standard distribution has been ported to not use ~[], then we can turn the lint back on.
It's now in the prelude.
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Aug 16, 2022
minor: Remove redundant --pre-release flag from publish
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 5, 2023
According to https://code.visualstudio.com/api/working-with-extensions/publishing-extension#prerelease-extensions, when publishing pre-release versions, `--pre-release` must also be passed in the publish step. Currently the behavior with and without the flag seems to be the same, but since it's documented to be required, don't rely on this staying that way. This flag was previously removed in rust-lang#13020, so this partially reverts that change.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 5, 2023
…, r=lnicola Specify `--pre-release` when publishing vsce nightly According to https://code.visualstudio.com/api/working-with-extensions/publishing-extension#prerelease-extensions, when publishing pre-release versions, `--pre-release` must also be passed in the publish step. Currently the behavior with and without the flag seems to be the same, but since it's documented to be required, don't rely on this staying that way. This flag was previously removed in rust-lang#13020, so this partially reverts that change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commits have the details.