Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crater for rustdoc test merging #130285

Closed
wants to merge 1 commit into from

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Sep 12, 2024

Crater run for #126245

@ehuss ehuss self-assigned this Sep 12, 2024
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Sep 12, 2024
@ehuss
Copy link
Contributor Author

ehuss commented Sep 12, 2024

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 12, 2024
@bors
Copy link
Contributor

bors commented Sep 12, 2024

⌛ Trying commit 80e581a with merge 024495a...

@rust-log-analyzer

This comment was marked as resolved.

@bors
Copy link
Contributor

bors commented Sep 12, 2024

☀️ Try build successful - checks-actions
Build commit: 024495a (024495a232636f1f9407d7695b2be51edc2c51bd)

@ehuss
Copy link
Contributor Author

ehuss commented Sep 12, 2024

@craterbot build-and-test

@craterbot
Copy link
Collaborator

🚨 Error: failed to parse the command

🆘 If you have any trouble with Crater please ping @rust-lang/infra!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@ehuss
Copy link
Contributor Author

ehuss commented Sep 12, 2024

@craterbot run mode=build-and-test

@craterbot
Copy link
Collaborator

👌 Experiment pr-130285 created and queued.
🤖 Automatically detected try build 024495a
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 12, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 14, 2024
[CRATER] Crater rollup

This is a crater rollup of:
* rust-lang#124141
* rust-lang#130285
* rust-lang#130367

**What is a crater rollup?** It's simply a (manually set-up) crater job that is run on all of the containing PRs together, and then we can set the crates list for each of these jobs to *just* the list of failures after it's done. It should cut out on the bulk of "normal" crates that do nothing and simply just waste time to build without being affected by the union of all of these changes.

After this is finished, I will adjust all of the jobs to use only the list of failed crates. That should significantly speed up these jobs from taking like ~6 days to taking ~2. See the last time I did this: rust-lang#129660.

Given that rust-lang#130285 is running in build-and-test mode, let's run all of them in build-and-test mode.
@craterbot
Copy link
Collaborator

🚧 Experiment pr-130285 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-130285 is completed!
📊 266 regressed and 122 fixed (512215 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Sep 21, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 1, 2024
…es, r=<try>

Use environment variables instead of command line arguments for merged doctests

Fixes [rust-lang#130796](rust-lang#130796).

Before merging this one, let's first ensure it has a smaller impact compared to command line arguments (results can be seen [here](rust-lang#130285)). I'll start a crater run once CI passed.

cc `@ehuss`
r? `@notriddle`
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 1, 2024
…es, r=<try>

Use environment variables instead of command line arguments for merged doctests

Fixes [rust-lang#130796](rust-lang#130796).

Before merging this one, let's first ensure it has a smaller impact compared to command line arguments (results can be seen [here](rust-lang#130285)). I'll start a crater run once CI passed.

cc `@ehuss`
r? `@notriddle`
@ehuss ehuss closed this Oct 9, 2024
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Oct 15, 2024
…bles, r=notriddle

Use environment variables instead of command line arguments for merged doctests

Fixes [rust-lang#130796](rust-lang#130796).

Before merging this one, let's first ensure it has a smaller impact compared to command line arguments (results can be seen [here](rust-lang#130285)). I'll start a crater run once CI passed.

cc `@ehuss`
r? `@notriddle`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 15, 2024
…bles, r=notriddle

Use environment variables instead of command line arguments for merged doctests

Fixes [rust-lang#130796](rust-lang#130796).

Before merging this one, let's first ensure it has a smaller impact compared to command line arguments (results can be seen [here](rust-lang#130285)). I'll start a crater run once CI passed.

cc ``@ehuss``
r? ``@notriddle``
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 15, 2024
Rollup merge of rust-lang#131095 - GuillaumeGomez:switch-to-env-variables, r=notriddle

Use environment variables instead of command line arguments for merged doctests

Fixes [rust-lang#130796](rust-lang#130796).

Before merging this one, let's first ensure it has a smaller impact compared to command line arguments (results can be seen [here](rust-lang#130285)). I'll start a crater run once CI passed.

cc ``@ehuss``
r? ``@notriddle``
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Oct 17, 2024
…otriddle

Use environment variables instead of command line arguments for merged doctests

Fixes [#130796](rust-lang/rust#130796).

Before merging this one, let's first ensure it has a smaller impact compared to command line arguments (results can be seen [here](rust-lang/rust#130285)). I'll start a crater run once CI passed.

cc ``@ehuss``
r? ``@notriddle``
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants