Skip to content

Mark OnceState::poison as pub #130330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Mark OnceState::poison as pub #130330

wants to merge 1 commit into from

Conversation

caass
Copy link
Contributor

@caass caass commented Sep 13, 2024

tracking issue: #130327

@rustbot
Copy link
Collaborator

rustbot commented Sep 13, 2024

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 13, 2024
@caass caass mentioned this pull request Sep 13, 2024
Closed
3 tasks
GrigorenkoPV
GrigorenkoPV reviewed Sep 15, 2024
View reviewed changes
library/std/src/sync/once.rs
@@ -365,9 +381,9 @@ impl OnceState {
}

/// Poison the associated [`Once`] without explicitly panicking.
// NOTE: This is currently only exposed for `OnceLock`.
#[unstable(feature = "once_poison_pub", issue = "130327")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tracking issue seems to have a different name for the feature

@Amanieu
Copy link
Member

Amanieu commented Sep 18, 2024

Please fix the feature name either here or in the tracking issue.

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 18, 2024
@alex-semenyuk
Copy link
Member

@caass
From wg-triage. Do you have updates on this PR

@Dylan-DPC
Copy link
Member

Closing this as inactive. Feel free to reöpen this pr or create a new pr if you get the time to work on this. Thanks

@Dylan-DPC Dylan-DPC closed this Nov 20, 2024
@Dylan-DPC Dylan-DPC added S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 20, 2024
@GrigorenkoPV GrigorenkoPV mentioned this pull request Nov 20, 2024
Closed
@cyrgani
Copy link
Contributor

cyrgani commented Feb 17, 2025 •
edited
Loading

@rustbot label -S-inactive
(declined in rust-lang/libs-team#509)

@rustbot
Copy link
Collaborator

rustbot commented Feb 17, 2025

Error: Parsing relabel command in comment failed: ...'S-inactive' | error: a label delta at >| ': declined'...

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

@rustbot rustbot removed the S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrigorenkoPV GrigorenkoPV GrigorenkoPV left review comments

Assignees

@Amanieu Amanieu

Labels
T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@caass @rustbot @Amanieu @alex-semenyuk @Dylan-DPC @cyrgani @GrigorenkoPV