Mark OnceState::poison as pub
#133240
Mark OnceState::poison as pub
#133240
Conversation
rustbot
added
S-waiting-on-review
library/std/src/sync/once.rs
Outdated
| /// | ||
| /// Poison a [`Once`] by explicitly calling [`OnceState::poison`]: | ||
| /// | ||
| /// ``` | ||
| /// #![feature(once_poison_pub)] | ||
| /// | ||
| /// use std::sync::Once; | ||
| /// | ||
| /// static INIT: Once = Once::new(); | ||
| /// | ||
| /// // poison the once without panicking | ||
| /// INIT.call_once_force(|p| p.poison()); | ||
| /// INIT.call_once_force(|p| assert!(p.is_poisoned())); | ||
| /// ``` |
There was a problem hiding this comment.
These docs look a bit off, maybe from the rebase? This example would be better in the docs for poison, and the heading "Poison a [Once] by panicking in a call_once closure:" is added twice (once here, once above the existing example).
|
It looks like this hasn't had an ACP or libs-api approval yet r? libs-api |
rustbot
added
the
T-libs-api
This comment has been minimized.
This comment has been minimized.
GrigorenkoPV
force-pushed
the
once_state_poison_pub
branch
from
c6e96c7 to
967fb97
Compare
|
@GrigorenkoPV it is probably easiest to move this forward if you file an ACP at https://github.com/rust-lang/libs-team/issues, could you do that? |
Done: @rustbot label +S-waiting-on-ACP |
rustbot
added
the
S-waiting-on-ACP
|
☔ The latest upstream changes (presumably #134692) made this pull request unmergeable. Please resolve the merge conflicts. |
GrigorenkoPV
force-pushed
the
once_state_poison_pub
branch
from
967fb97 to
4f6e873
Compare
There was a problem hiding this comment.
In rust-lang/libs-team#509 (comment) the ACP for this feature was not accepted by the standard library team.
Thanks anyway for the PR!
Rebase of #130330 with #130330 (comment) fixed
Tracking issue: #130327