-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Fix x test compiler
unit tests under rust.parallel-compiler = true
#130345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1870,7 +1870,9 @@ declare_lint! { | |
/// | ||
/// ### Example | ||
/// | ||
/// ```rust,compile_fail | ||
#[cfg_attr(bootstrap, doc = "```ignore")] | ||
#[cfg_attr(not(bootstrap), doc = "```rust,compile_fail")] | ||
Comment on lines
+1873
to
+1874
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks to Boxy for helping me figure out how to actually do this. ✨ There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unfortunately we have multiple checks using hand-rolled parsers that don't understand this pattern, so I've had to “fix” one and trick the other. |
||
// ``` // Trick tidy's backtick count. Remove on bootstrap bump. #[cfg(not(bootstrap))] | ||
/// #![deny(elided_named_lifetimes)] | ||
/// struct Foo; | ||
/// impl Foo { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disclosure:
x test tidy
doesn't seem to actually enforce alphabetical ordering of these sub-lists, so the alphabetical check only applies to the top-level features.