Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std::net: Solaris supports SOCK_CLOEXEC as well since 11.4. #130361

Merged
merged 1 commit into from
Dec 15, 2024
Merged

std::net: Solaris supports SOCK_CLOEXEC as well since 11.4. #130361

merged 1 commit into from
Dec 15, 2024
+1 −0

Conversation

devnexen
Copy link
Contributor

@devnexen devnexen commented Sep 14, 2024 •
edited by cuviper
Loading

try-job: dist-various-2

@rustbot
Copy link
Collaborator

rustbot commented Sep 14, 2024

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 14, 2024
@cuviper
Copy link
Member

cuviper commented Sep 16, 2024

Hmm, I don't know if we have any proper target owner for Solaris to make decisions about the minimum version that Rust should support, but it appears Oracle is supporting Solaris 11.3 until January 2027.

https://en.wikipedia.org/wiki/Oracle_Solaris#Version_history

@cuviper
Copy link
Member

cuviper commented Nov 20, 2024

I brought this up on Zulip: https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Solaris.20baseline

@psumbera you were mentioned as a potential target maintainer -- do you have any opinion on this change?

@psumbera
Copy link
Contributor

I brought this up on Zulip: https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Solaris.20baseline

@psumbera you were mentioned as a potential target maintainer -- do you have any opinion on this change?

Solaris 11.4 should be only relevant Solaris version for Rust. Don't bother with 11.3 version.

I should add myself to https://github.com/rust-lang/rust/tree/8adb4b30f40e6fbd21dc1ba26c3301c7eeb6de3c/src/doc/rustc/src/platform-support for Solaris. But I haven't created pull request for that yet.

@cuviper
Copy link
Member

cuviper commented Nov 20, 2024

Thanks for the quick response! We should update the main platform support doc too, which just says "Solaris 11" now, but I'm continuing the discussion on Zulip to see if we need any particular approval for that.

I'm queuing dist-various-2 for a try job to make sure this builds, but I expect it will because the libc::SOCK_CLOEXEC constant doesn't depend on the real toolchain anyway, and we won't be executing any of this in CI either.

@bors try

@cuviper
Copy link
Member

cuviper commented Nov 20, 2024

Let me try to reawaken bors...

@cuviper cuviper closed this Nov 20, 2024
@cuviper cuviper reopened this Nov 20, 2024
@cuviper
Copy link
Member

cuviper commented Nov 20, 2024

@bors try

@bors
Copy link
Contributor

bors commented Nov 20, 2024

⌛ Trying commit 22dac23 with merge 686f591...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 20, 2024
@bors
Auto merge of rust-lang#130361 - devnexen:sock_cloexec_solaris, r=<try>
686f591 
std::net: Solaris supports `SOCK_CLOEXEC` as well since 11.4.

try-job: dist-various-2
@bors
Copy link
Contributor

bors commented Nov 20, 2024

☀️ Try build successful - checks-actions
Build commit: 686f591 (686f591a8177049c25255a71a470fb9a36d701eb)

@cuviper
Copy link
Member

cuviper commented Dec 15, 2024

We're clear now that the baseline change merged in #133293.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 15, 2024

📌 Commit 22dac23 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 15, 2024
@Zalathar Zalathar mentioned this pull request Dec 15, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 15, 2024
@bors
Auto merge of rust-lang#134332 - Zalathar:rollup-oe23hkw, r=Zalathar
0894fb0 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#130361 (std::net: Solaris supports `SOCK_CLOEXEC` as well since 11.4.)
 - rust-lang#133406 (Add value accessor methods to `Mutex` and `RwLock`)
 - rust-lang#133633 (don't show the full linker args unless `--verbose` is passed)
 - rust-lang#134285 (Add some convenience helper methods on `hir::Safety`)
 - rust-lang#134310 (Add clarity to the examples of some `Vec` & `VecDeque` methods)
 - rust-lang#134313 (Don't make a def id for `impl_trait_in_bindings`)
 - rust-lang#134315 (A couple of polonius fact generation cleanups)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit acdcd3a into rust-lang:master Dec 15, 2024
13 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 15, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 15, 2024
@rust-timer
Unrolled build for rust-lang#130361
2873195 
Rollup merge of rust-lang#130361 - devnexen:sock_cloexec_solaris, r=cuviper

std::net: Solaris supports `SOCK_CLOEXEC` as well since 11.4.

try-job: dist-various-2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cuviper cuviper

Labels
O-unix Operating system: Unix-like S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.85.0
Development

Successfully merging this pull request may close these issues.
5 participants
@devnexen @rustbot @cuviper @psumbera @bors