-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump cc dependency #130406
Bump cc dependency #130406
Conversation
arttet
commented
Sep 15, 2024
•
edited
Loading
edited
- The issue was fixed in the PR
- The build artifacts of arm64e-apple-darwin can be found here
rustbot has assigned @Mark-Simulacrum. Use |
This comment has been minimized.
This comment has been minimized.
r? onur-ozkan bjorn3 |
Last time we had a lot of trouble on bumping @bors r+ rollup=iffy |
Bump cc dependency * The [issue](rust-lang#130231) was fixed in the [PR](rust-lang/cc-rs#1207) * The build artifacts of arm64e-apple-darwin can be found [here](https://github.com/arttet/rust-compiler-builder/actions/runs/10902308425)
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
Hey @onur-ozkan Could you please assist me to find a reason of this fault? It seems CI hallucinates. |
Hey @onur-ozkan I have double-checked the results of CI and haven't found anything related with my changes. Can we please run CI again? |
Yeah, seems suspicious. @bors retry |
Hey @onur-ozkan, Please note that CI hasn't started yet. |
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (b0af276): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 3.8%, secondary 2.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary 5.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 768.752s -> 769.526s (0.10%) |