Do precise capturing arg validation in resolve #130414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in diagnostic error codes |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
compiler-errors
force-pushed
the
precise-capturing-arg-valid
branch
from
a9617b4 to
10af205
Compare
jieyouxu
approved these changes
Sep 16, 2024
jieyouxu
added
S-waiting-on-author
|
Please r=me after fixing the typo in error code docs since I think those are user-facing. |
compiler-errors
force-pushed
the
precise-capturing-arg-valid
branch
from
10af205 to
ae8b460
Compare
|
@bors r=jieyouxu |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (3a22be3): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 759.454s -> 758.941s (-0.07%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the validation of precise capturing args (
use<T, N>) out ofresolve_bound_varsand intorustc_resolve. This both simplifies the impl and fixes a bug when we haveuse<arg>whereargis one of the function args.This also introduces new error codes specifically for precise capturing, to avoid reusing the other error codes which are not as accurate.
Fixes #130399