move enzyme flags from general cargo to rustc-specific cargo #130648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: onur-ozkan <work@onurozkan.dev>
rustbot
added
S-waiting-on-review
|
I can confirm that cherry-picking this pr (and a minor fix due to being 2 weeks behind) worked for the full rustc-ad fork, I could run all of our (not yet upstreamed) tests: https://github.com/rust-lang/rust/pull/130648/files, so it would be great if this gets approved, since it will enable running enzyme in the compiler explorer. |
|
@bors r+ |
bors
added
S-waiting-on-bors
|
We don't (currently) build Enzyme/autodiff by default, so I think this could just be rollup=allways, since it won't affect the CI builds. |
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Sep 22, 2024
move enzyme flags from general cargo to rustc-specific cargo Resolves rust-lang#130637.
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Sep 22, 2024
move enzyme flags from general cargo to rustc-specific cargo Resolves rust-lang#130637.
This was referenced Sep 22, 2024
We usually rollup PRs unless they are explicitly tagged with rollup=never/iffy. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 22, 2024
…kingjubilee Rollup of 5 pull requests Successful merges: - rust-lang#130648 (move enzyme flags from general cargo to rustc-specific cargo) - rust-lang#130650 (Fixup Apple target's description strings) - rust-lang#130664 (Generate line numbers for non-rust code examples as well) - rust-lang#130665 (Prevent Deduplication of `LongRunningWarn`) - rust-lang#130669 (tests: Test that `extern "C" fn` ptrs lint on slices) r? `@ghost` `@rustbot` modify labels: rollup
7 tasks
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 22, 2024
Rollup merge of rust-lang#130648 - onur-ozkan:enzyme-linking, r=Kobzol move enzyme flags from general cargo to rustc-specific cargo Resolves rust-lang#130637.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #130637.
Tracking: