-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump stage0 to beta-2024-09-22 and rustfmt to nightly-2024-09-22 #130724
Conversation
r? cuviper (or reassign; not totally sure who's responsible for reviewing stage0 bumps!) |
@bors p=10 since it's very bitrotty |
@bors r+ |
This comment has been minimized.
This comment has been minimized.
Sorting probably changed something with rustdoc-js :( Let me bless that really quick, I guess. @bors r- |
Finished benchmarking commit (66b0b29): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -0.5%, secondary -0.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary -0.5%, secondary -2.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 770.325s -> 770.556s (0.03%) |
This was a pretty massive change, maybe we should add it to git blame ignore? |
Yep definitely. That was gonna be my follow-up once it lands, but it's 03:10 here. It would be very cool if you put up a PR, but if you don't, then I can do it in the morning. |
…ompiler-errors Add rustfmt 2024 reformatting to git blame ignore rust-lang#130724 essentially reformatted the world, so we should add it to the git blame ignore list. Tested with `git blame compiler/rustc_abi/src/lib.rs -L1137,1146`. I first thought that I have to ignore the merge commit, but it seems like the actual commit that did the reformatting should be ignored instead. r? `@compiler-errors`
…ompiler-errors Add rustfmt 2024 reformatting to git blame ignore rust-lang#130724 essentially reformatted the world, so we should add it to the git blame ignore list. Tested with `git blame compiler/rustc_abi/src/lib.rs -L1137,1146`. I first thought that I have to ignore the merge commit, but it seems like the actual commit that did the reformatting should be ignored instead. r? ``@compiler-errors``
Rollup merge of rust-lang#130736 - Kobzol:rustfmt-2024-git-blame, r=compiler-errors Add rustfmt 2024 reformatting to git blame ignore rust-lang#130724 essentially reformatted the world, so we should add it to the git blame ignore list. Tested with `git blame compiler/rustc_abi/src/lib.rs -L1137,1146`. I first thought that I have to ignore the merge commit, but it seems like the actual commit that did the reformatting should be ignored instead. r? ``@compiler-errors``
…rrors Add rustfmt 2024 reformatting to git blame ignore rust-lang/rust#130724 essentially reformatted the world, so we should add it to the git blame ignore list. Tested with `git blame compiler/rustc_abi/src/lib.rs -L1137,1146`. I first thought that I have to ignore the merge commit, but it seems like the actual commit that did the reformatting should be ignored instead. r? ``@compiler-errors``
I'm doing this to apply the changes to version sorting (rust-lang/rustfmt#6284) that have occurred since rustfmt last upgraded (and a few other miscellaneous changes, like changes to expression overflowing: rust-lang/rustfmt#6260). Eagerly updating rustfmt and formatting-the-world will ideally move some of the pressure off of the beta bump which will happen at the beginning of the next release cycle.
You can verify this is correct by checking out the changes, reverting the last commit, reapplying them, and diffing the changes:
Or just take my word for it? Up to the reviewer.
r? release