Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Remove spuriously failing vec-tryinto-array codegen test #130726

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

workingjubilee
Copy link
Member

This has failed more than a couple of times now. It costs real time, money, and energy to deal with this, far more than this test is saving us.

@rustbot
Copy link
Collaborator

rustbot commented Sep 22, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 22, 2024
@workingjubilee
Copy link
Member Author

As an alternative, someone with infra access could do the needful with the Docker images in our cache? I have no idea how anyone else can affect that.

@BoxyUwU
Copy link
Member

BoxyUwU commented Sep 23, 2024

r? @BoxyUwU
@bors r+ rollup

since this is just a codegen test for perf stuff it seems very low value to keep around if it's causing PRs to spuriously fail to merge

@bors
Copy link
Contributor

bors commented Sep 23, 2024

📌 Commit ff3a9f4 has been approved by BoxyUwU

It is now in the queue for this repository.

@rustbot rustbot assigned BoxyUwU and unassigned Mark-Simulacrum Sep 23, 2024
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 23, 2024
@BoxyUwU
Copy link
Member

BoxyUwU commented Sep 23, 2024

This PR should reopen #111508 does "unfixes" actually do that? it doesnt seem to underline it

@workingjubilee
Copy link
Member Author

It does not.

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Sep 23, 2024
…is-test, r=BoxyUwU

tests: Remove spuriously failing vec-tryinto-array codegen test

This has failed more than a couple of times now. It costs real time, money, and energy to deal with this, far more than this test is saving us.
@workingjubilee
Copy link
Member Author

Reopened that issue.

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 23, 2024
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#129550 (Add str.as_str() for easy Deref to string slices)
 - rust-lang#130344 (Handle unsized consts with type `str`  in v0 symbol mangling)
 - rust-lang#130659 (Support `char::encode_utf16` in const scenarios.)
 - rust-lang#130705 (No longer mark RTN as incomplete)
 - rust-lang#130712 (Don't call `ty::Const::normalize` in error reporting)
 - rust-lang#130713 (Mark `u8::make_ascii_uppercase` and `u8::make_ascii_lowercase` as const.)
 - rust-lang#130714 (Introduce `structurally_normalize_const`, use it in `rustc_hir_typeck`)
 - rust-lang#130715 (Replace calls to `ty::Const::{try_}eval` in mir build/pattern analysis)
 - rust-lang#130723 (Add test for `available_parallelism()`)
 - rust-lang#130726 (tests: Remove spuriously failing vec-tryinto-array codegen test)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 693269b into rust-lang:master Sep 23, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 23, 2024
Rollup merge of rust-lang#130726 - workingjubilee:put-the-spurs-to-this-test, r=BoxyUwU

tests: Remove spuriously failing vec-tryinto-array codegen test

This has failed more than a couple of times now. It costs real time, money, and energy to deal with this, far more than this test is saving us.
@rustbot rustbot added this to the 1.83.0 milestone Sep 23, 2024
@workingjubilee workingjubilee deleted the put-the-spurs-to-this-test branch September 23, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

issue-111508-vec-tryinto-array.rs fails spuriously on x86_64-gnu-llvm-19
5 participants