Suggest adding missing braces in const block pattern
#130751
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
GrigorenkoPV
force-pushed
the
missing-{-in-const
branch
from
7a7b0b1 to
bb10afd
Compare
|
☔ The latest upstream changes (presumably #133135) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Unasigning myself from review since this hasn't had any activity in two month, is in a draft state and has some merge conflcits. if you continue this work feel free to reassign me or roll a new reviewer |
Previously it would only suggest wrapping the code in braces in regular expressions; now it does it in patterns too. This is a squashed rebase of rust-lang#78173
GrigorenkoPV
force-pushed
the
missing-{-in-const
branch
from
bb10afd to
31af5b0
Compare
|
@GrigorenkoPV does this still need to be a draft? or is this ready for review? if it's the latter then you can mark it as »ready for review« and the next step would be to assign a random reviewer for this. Thanks |
|
☔ The latest upstream changes (presumably #139897) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #78168.
Builds upon work done in #78173.
TODO:
tests/ui/parser/bad-if-statements.stderrtests/ui/parser/keyword-const-as-identifier.rs: Suggest adding missing braces inconstblock pattern #78173 (review)constblock pattern #78173 (comment)