Implement RFC 3678: Final trait methods#130802
Closed
compiler-errors wants to merge 6 commits intorust-lang:masterfrom
Closed
Implement RFC 3678: Final trait methods#130802compiler-errors wants to merge 6 commits intorust-lang:masterfrom
compiler-errors wants to merge 6 commits intorust-lang:masterfrom
Conversation
rustbot
added
A-rustdoc-json
This comment has been minimized.
This comment has been minimized.
Member
Note that doing so could also be a pessimization -- see conversation in rust-lang/rfcs#3678 (comment) -- so I think that's absolutely the right choice for now, and might even be the right choice going forward too. |
Member
|
@compiler-errors You are absolutely incredible; I did not expect someone to pick this up for implementation so quickly. Thank you! ❤️ |
7 tasks
Contributor
Author
|
This will need to be reworked almost totally since it seems that @joshtriplett is going to rewrite his RFC. |
Member
|
@compiler-errors I don't anticipate making an utter rewrite here, just changing |
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Feb 17, 2026
…, r=fee1-dead Implement RFC 3678: Final trait methods Tracking: rust-lang#131179 This PR is based on rust-lang#130802, with some minor changes and conflict resolution. Futhermore, this PR excludes final methods from the vtable of a dyn Trait. And some excerpt from the original PR description: > Implements the surface part of rust-lang/rfcs#3678. > > I'm using the word "method" in the title, but in the diagnostics and the feature gate I used "associated function", since that's more accurate. cc @joshtriplett
rust-timer
added a commit
that referenced
this pull request
Feb 17, 2026
Rollup merge of #151783 - mu001999-contrib:impl/final-method, r=fee1-dead Implement RFC 3678: Final trait methods Tracking: #131179 This PR is based on #130802, with some minor changes and conflict resolution. Futhermore, this PR excludes final methods from the vtable of a dyn Trait. And some excerpt from the original PR description: > Implements the surface part of rust-lang/rfcs#3678. > > I'm using the word "method" in the title, but in the diagnostics and the feature gate I used "associated function", since that's more accurate. cc @joshtriplett
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Feb 18, 2026
…dead Implement RFC 3678: Final trait methods Tracking: rust-lang/rust#131179 This PR is based on rust-lang/rust#130802, with some minor changes and conflict resolution. Futhermore, this PR excludes final methods from the vtable of a dyn Trait. And some excerpt from the original PR description: > Implements the surface part of rust-lang/rfcs#3678. > > I'm using the word "method" in the title, but in the diagnostics and the feature gate I used "associated function", since that's more accurate. cc @joshtriplett
flip1995
pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Feb 19, 2026
…dead Implement RFC 3678: Final trait methods Tracking: rust-lang/rust#131179 This PR is based on rust-lang/rust#130802, with some minor changes and conflict resolution. Futhermore, this PR excludes final methods from the vtable of a dyn Trait. And some excerpt from the original PR description: > Implements the surface part of rust-lang/rfcs#3678. > > I'm using the word "method" in the title, but in the diagnostics and the feature gate I used "associated function", since that's more accurate. cc @joshtriplett
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the surface part of RFC 3678. Gonna keep this open as a draft until the RFC finishes FCP.
What it doesn't implement are any optimizations that can be done on final trait methods, such as excluding them from the vtable of a
dyn Trait. This also doesn't implementfinalfor other trait items.I'm using the word "method" in the title, but in the diagnostics and the feature gate I used "associated function", since that's more accurate.
r? @ghost
Tracking:
finalmethods) #131179