-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump few deps #130874
bump few deps #130874
Conversation
rustbot has assigned @Mark-Simulacrum. Use |
Some changes occurred in src/tools/compiletest cc @jieyouxu These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumps LGTM, I'll let Mark double-check though. I'm surprised if nothing breaks especially for windows
crate bumps from 0.52.0
-> 0.57.0
.
Well, compiler builds locally on my win machine; hopefully no stike back from memchr. |
This comment has been minimized.
This comment has been minimized.
The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging. |
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #129624) made this pull request unmergeable. Please resolve the merge conflicts. |
cargo_metadata, thorin-dwp, windows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually since this doesn't touch libs deps, this seems fine.
Thanks! |
bump few deps Bumps cargo_metadata, thorin-dwp, windows. Should dedupe some crates around.
💔 Test failed - checks-actions |
@bors retry CI can't reach docker right now #130946 (comment) |
☀️ Test successful - checks-actions |
Finished benchmarking commit (851f698): comparison URL. Overall result: ❌ regressions - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (primary 4.1%, secondary -2.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 774.209s -> 771.075s (-0.40%) |
@rustbot label: +perf-regression-triaged |
In windows 0.53 (https://github.com/microsoft/windows-rs/releases/tag/0.53.0) was added microsoft/windows-rs#2786 and now rustc_driver links to propsys.dll, but i can't find why it's linked and where actually used yet. microsoft/windows-rs#3282 changes something around, but not released yet, maybe fixed this? Checked, issue fixed in unreleased version of |
Bumps cargo_metadata, thorin-dwp, windows.
Should dedupe some crates around.