Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump few deps #130874

Merged
merged 2 commits into from
Sep 28, 2024
Merged

bump few deps #130874

merged 2 commits into from
Sep 28, 2024

Conversation

klensy
Copy link
Contributor

@klensy klensy commented Sep 26, 2024

Bumps cargo_metadata, thorin-dwp, windows.

Should dedupe some crates around.

@rustbot
Copy link
Collaborator

rustbot commented Sep 26, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 26, 2024
@rustbot
Copy link
Collaborator

rustbot commented Sep 26, 2024

Some changes occurred in src/tools/compiletest

cc @jieyouxu

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumps LGTM, I'll let Mark double-check though. I'm surprised if nothing breaks especially for windows crate bumps from 0.52.0 -> 0.57.0.

@klensy
Copy link
Contributor Author

klensy commented Sep 26, 2024

Well, compiler builds locally on my win machine; hopefully no stike back from memchr.

@rust-log-analyzer

This comment has been minimized.

@rustbot
Copy link
Collaborator

rustbot commented Sep 26, 2024

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @wesleywiser

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Sep 26, 2024

☔ The latest upstream changes (presumably #129624) made this pull request unmergeable. Please resolve the merge conflicts.

cargo_metadata, thorin-dwp, windows
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually since this doesn't touch libs deps, this seems fine.

@jieyouxu jieyouxu assigned jieyouxu and unassigned Mark-Simulacrum Sep 27, 2024
@jieyouxu
Copy link
Member

Thanks!
@bors r+ rollup=iffy (bump deps)

@bors
Copy link
Contributor

bors commented Sep 27, 2024

📌 Commit 62d92e6 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 27, 2024
@bors
Copy link
Contributor

bors commented Sep 27, 2024

⌛ Testing commit 62d92e6 with merge 739668d...

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
bump few deps

Bumps cargo_metadata, thorin-dwp, windows.

Should dedupe some crates around.
@bors
Copy link
Contributor

bors commented Sep 27, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 27, 2024
@tgross35
Copy link
Contributor

@bors retry

CI can't reach docker right now #130946 (comment)

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 27, 2024
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Contributor

bors commented Sep 28, 2024

⌛ Testing commit 62d92e6 with merge 851f698...

@bors
Copy link
Contributor

bors commented Sep 28, 2024

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 851f698 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 28, 2024
@bors bors merged commit 851f698 into rust-lang:master Sep 28, 2024
7 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Sep 28, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (851f698): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.4% [3.4%, 3.4%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 3.4% [3.4%, 3.4%] 1

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary 4.1%, secondary -2.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
4.1% [3.3%, 4.9%] 2
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.2% [-2.2%, -2.2%] 1
All ❌✅ (primary) 4.1% [3.3%, 4.9%] 2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 774.209s -> 771.075s (-0.40%)
Artifact size: 341.42 MiB -> 341.37 MiB (-0.02%)

@rustbot rustbot added the perf-regression Performance regression. label Sep 28, 2024
@Kobzol
Copy link
Contributor

Kobzol commented Sep 28, 2024

Noise:
image

@Kobzol
Copy link
Contributor

Kobzol commented Sep 28, 2024

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Sep 28, 2024
@klensy
Copy link
Contributor Author

klensy commented Oct 4, 2024

In windows 0.53 (https://github.com/microsoft/windows-rs/releases/tag/0.53.0) was added microsoft/windows-rs#2786 and now rustc_driver links to propsys.dll, but i can't find why it's linked and where actually used yet.

microsoft/windows-rs#3282 changes something around, but not released yet, maybe fixed this?

Checked, issue fixed in unreleased version of windows crate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants