Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo in triagebot.toml #130915

Merged
merged 1 commit into from
Sep 28, 2024
Merged

fix typo in triagebot.toml #130915

merged 1 commit into from
Sep 28, 2024

Conversation

naskya
Copy link
Contributor

@naskya naskya commented Sep 27, 2024

This pull request fixes a minor typo in the triagebot config file.

@rustbot
Copy link
Collaborator

rustbot commented Sep 27, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 27, 2024
@rustbot
Copy link
Collaborator

rustbot commented Sep 27, 2024

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

workingjubilee
workingjubilee reviewed Sep 27, 2024
View reviewed changes
triagebot.toml Outdated Show resolved Hide resolved
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@compiler-errors
Copy link
Member

I would appreciate if you squashed this into a single commit as well!

jieyouxu
jieyouxu approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 27, 2024

📌 Commit 8ba2c7d has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 27, 2024
@jieyouxu jieyouxu assigned jieyouxu and unassigned Mark-Simulacrum Sep 27, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 27, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
@bors
Auto merge of rust-lang#130946 - matthiaskrgr:rollup-ia4mf0y, r=matth…
442bdde 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#130718 (Cleanup some known-bug issues)
 - rust-lang#130730 (Reorganize Test Headers)
 - rust-lang#130826 (Compiler: Rename "object safe" to "dyn compatible")
 - rust-lang#130915 (fix typo in triagebot.toml)
 - rust-lang#130926 (Update cc to 1.1.22 in library/)
 - rust-lang#130932 (etc: Add sample rust-analyzer configs for eglot & helix)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
@bors
Auto merge of rust-lang#130946 - matthiaskrgr:rollup-ia4mf0y, r=matth…
784b6f7 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#130718 (Cleanup some known-bug issues)
 - rust-lang#130730 (Reorganize Test Headers)
 - rust-lang#130826 (Compiler: Rename "object safe" to "dyn compatible")
 - rust-lang#130915 (fix typo in triagebot.toml)
 - rust-lang#130926 (Update cc to 1.1.22 in library/)
 - rust-lang#130932 (etc: Add sample rust-analyzer configs for eglot & helix)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
@bors
Auto merge of rust-lang#130946 - matthiaskrgr:rollup-ia4mf0y, r=matth…
83e4e18 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#130718 (Cleanup some known-bug issues)
 - rust-lang#130730 (Reorganize Test Headers)
 - rust-lang#130826 (Compiler: Rename "object safe" to "dyn compatible")
 - rust-lang#130915 (fix typo in triagebot.toml)
 - rust-lang#130926 (Update cc to 1.1.22 in library/)
 - rust-lang#130932 (etc: Add sample rust-analyzer configs for eglot & helix)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6c362bf into rust-lang:master Sep 28, 2024
6 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Sep 28, 2024
@naskya naskya deleted the fix/typo branch September 28, 2024 00:18
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 28, 2024
@rust-timer
Unrolled build for rust-lang#130915
cf868bf 
Rollup merge of rust-lang#130915 - naskya:fix/typo, r=jieyouxu

fix typo in triagebot.toml

This pull request fixes a minor typo in the triagebot config file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@workingjubilee workingjubilee workingjubilee left review comments

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.83.0
Development

Successfully merging this pull request may close these issues.
8 participants
@naskya @rustbot @rust-log-analyzer @compiler-errors @jieyouxu @bors @workingjubilee @Mark-Simulacrum