Some cleanup in std::io::buffered #13092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| //! | ||
| //! It can be excessively inefficient to work directly with a `Reader` or | ||
| //! `Writer`. Every call to `read` or `write` on `TcpStream` results in a | ||
| //! system call, for example. This module provides structures that wrap |
There was a problem hiding this comment.
I think "For example, ..." would be better here. I know it's not new :).
There was a problem hiding this comment.
Agreed. I also just remembered that buffered is a private module now so I'm splitting this paragraph up and moving it to the various structs.
`Vec` is now used for the internal buffer instead of `~[]`. Some module level documentation somehow ended up attached to `BufferedReader` so I fixed that as well.
|
@thestinger updated. |
bors
added a commit
that referenced
this pull request
Mar 23, 2014
`Vec` is now used for the internal buffer instead of `~[]`. Some module level documentation somehow ended up attached to `BufferedReader` so I fixed that as well.
JohnTitor
pushed a commit
to JohnTitor/rust
that referenced
this pull request
Aug 30, 2022
fix: Fix reference autocompletions using incorrect offsets in macro inputs Fixes rust-lang/rust-analyzer#13035
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 20, 2025
…lang#13128) changelog: [`use_self`] Skip if inside macro expansions of a `impl Self` block Fixes rust-lang#13092. r? Alexendoo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vecis now used for the internal buffer instead of~[]. Some modulelevel documentation somehow ended up attached to
BufferedReaderso Ifixed that as well.