-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump cc
and run cargo update
for bootstrap
#130951
Conversation
Bump `cc` to 1.1.22, which includes a caching fix. Also run `cargo update` which does a minor increment on a few dependencies.
A job failed! Check out the build log: (web) (plain) Click to see the possible cause of the failure (guessed by this bot)
|
The differences in |
Looks like the dependency count stayed the same. The comment in the |
Hm, not sure why it looks like these are getting the network errors.
Yes, I thought so too :) I made this just to see what the changes looked like after the automation PR. But with |
cc also @ChrisDenton since you've been doing some of the |
Cc @onur-ozkan since you authored the comment at Lines 37 to 39 in a1fd235
cc update?
|
It's never clear tbh. We need to try and see if we need to make a change on bootstrap :) |
So let's just merge and see what breaks? Do you want to wait for some confirmation from soneone @tgross35? |
Oh no I just wanted to make sure I wasn't missing something, this is ready whenever you are :) |
Ok, let's try. @bors r+ rollup=never |
☀️ Test successful - checks-actions |
Finished benchmarking commit (63a0bdd): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results (primary 1.0%, secondary -3.6%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary -1.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 768.953s -> 768.228s (-0.09%) |
Bump
cc
to 1.1.22, which includes a caching fix. Also runcargo update
which does a minor increment on a few dependencies.