-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test indexmap#343 - using hashbrown 0.15 with HashTable #131099
Conversation
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
Test indexmap#343 - using hashbrown 0.15 with HashTable In indexmap-rs/indexmap#343, I've ported to hashbrown 0.15, which also requires a change from `RawTable` (now private) to `HashTable`. This PR is patching to use that unpublished branch so I can test rustc performance. r? ghost
This comment was marked as off-topic.
This comment was marked as off-topic.
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (a560a4e): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (secondary -0.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 771.847s -> 770.491s (-0.18%) |
Looks neutral with a dash of probably-noisy improvement. That's fine! |
In indexmap-rs/indexmap#343, I've ported to hashbrown 0.15, which also requires a change from
RawTable
(now private) toHashTable
. This PR is patching to use that unpublished branch so I can test rustc performance.r? ghost