Handle rustc_middle cases of rustc::potential_query_instability lint

[ismailarilik]

This PR removes #![allow(rustc::potential_query_instability)] line from compiler/rustc_middle/src/lib.rs and converts FxHash{Map,Set} types into FxIndex{Map,Set} to suppress lint errors.

A somewhat tracking issue: #84447

r? @compiler-errors

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @compiler-errors (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

[rustbot]

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

[bors]

☔ The latest upstream changes (presumably #131263) made this pull request unmergeable. Please resolve the merge conflicts.

[bors]

☔ The latest upstream changes (presumably #132282) made this pull request unmergeable. Please resolve the merge conflicts.

[compiler-errors]

I'm gonna re-roll this so this PR gets more attention, sorry for my inactivity.

r? compiler

But also reassigning to author sicne I think this PR still needs updating.

@rustbot author

[SparrowLii]

@ismailarilik Can you rebase the PR today? I'm in holiday tomorrow so I"d like to have a review before that :)

[SparrowLii]

r? compiler cause I'm going to the holidays in the next few days.

And I suggest to run a rustc perf when it's ready since this PR change the cache struct

[Dylan-DPC]

@ismailarilik any updates on this? thanks

[rustbot]

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git pull --rebase https://github.com/rust-lang/rust.git master
$ git push --force-with-lease

The following commits are merge commits:

• 8779cf4

[ismailarilik]

@ismailarilik any updates on this? thanks

Sorry, I missed the previous comment. I've just fixed conflicts. But since I have no access to the git tool in a machine nowadays, I had to do it using the web UI so there is a merge commit now. I can fix it later or feel free to fix.