Handle rustc_query_system cases of rustc::potential_query_instability lint

[ismailarilik]

This PR removes #![allow(rustc::potential_query_instability)] line from compiler/rustc_query_system/src/lib.rs and converts FxHash{Map,Set} types into FxIndex{Map,Set} to suppress lint errors.

A somewhat tracking issue: #84447

r? @compiler-errors

[rustbot]

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

[ismailarilik]

@rustbot author

[ismailarilik]

@rustbot review

[cjgillot]

Could you point to the place where each of these maps is iterated over?

[ismailarilik]

error: using `iter` can result in unstable query results
    --> compiler/rustc_query_system/src/dep_graph/graph.rs:1392:44
     |
1392 |             if let Some((node, _)) = shard.iter().find(|(_, index)| **index == dep_node_index) {
     |                                            ^^^^
     |
     = note: if you believe this case to be fine, allow this lint and add a comment explaining your rationale
     = note: `-D rustc::potential-query-instability` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(rustc::potential_query_instability)]`

error: using `values` can result in unstable query results
   --> compiler/rustc_query_system/src/dep_graph/serialized.rs:654:50
    |
654 |             let mut stats: Vec<_> = record_stats.values().collect();
    |                                                  ^^^^^^
    |
    = note: if you believe this case to be fine, allow this lint and add a comment explaining your rationale

error: using `iter` can result in unstable query results
  --> compiler/rustc_query_system/src/query/plumbing.rs:80:34
   |
80 |             for (k, v) in shard?.iter() {
   |                                  ^^^^
   |
   = note: if you believe this case to be fine, allow this lint and add a comment explaining your rationale

error: using `keys` can result in unstable query results
   --> compiler/rustc_query_system/src/query/job.rs:517:47
    |
517 |     let mut jobs: Vec<QueryJobId> = query_map.keys().cloned().collect();
    |                                               ^^^^
    |
    = note: if you believe this case to be fine, allow this lint and add a comment explaining your rationale

error: using `iter` can result in unstable query results
  --> compiler/rustc_query_system/src/query/caches.rs:62:33
   |
62 |             for (k, v) in shard.iter() {
   |                                 ^^^^
   |
   = note: if you believe this case to be fine, allow this lint and add a comment explaining your rationale

[cjgillot]

@ismailarilik that's not very helpful.
My question is: for each map whose type you are changing, where in code is it iterated over?
Just the iteration sites does not help me to connect to maps' creations.

The point is chosing for each map, what is the best course of action, between changing the type, and allowing the lint because the non-determinism does not show.

For instance, at graph.rs:1391, iterating is ok, as there can be at most one dep_node with the given dep_node_index. So allowing the lint is ok.

[ismailarilik]

For instance, at graph.rs:1391, iterating is ok, as there can be at most one dep_node with the given dep_node_index. So allowing the lint is ok.

Addressed here: 870d7c2

[ismailarilik]

My question is: for each map whose type you are changing, where in code is it iterated over?

In src/query/caches.rs:

• Line 26 (cache: Sharded<FxIndexMap<K, (V, DepNodeIndex)>>,) causes this lint to be triggered in line 62:

  for (k, v) in shard.iter() {
      f(k, &v.0, v.1);
  }

In src/query/job.rs:

• Line 33 (pub type QueryMap = FxIndexMap<QueryJobId, QueryJobInfo>;) causes this lint to be triggered in line 517:

  let mut jobs: Vec<QueryJobId> = query_map.keys().cloned().collect();

In src/query/plumbing.rs:

• Line 36 (active: Sharded<FxHashMap<K, QueryResult>>,) causes this lint to be triggered in line 80:

  for (k, v) in shard?.iter() {
      if let QueryResult::Started(ref job) = *v {
          active.push((*k, job.clone()));
      }
  }

[bors]

☔ The latest upstream changes (presumably #132282) made this pull request unmergeable. Please resolve the merge conflicts.