Skip to content

Cleanup old issue references #13122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2014
Merged

Cleanup old issue references #13122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
451160f
Cleanup fixed issue #10734 workaround
mstewartgallus Mar 24, 2014
ff2f2e8
Correct issue workaround references
mstewartgallus Mar 24, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions src/libnum/bigint.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,22 +406,22 @@ impl Integer for BigUint {
let mut d0 = d0;
let mut prod = b * d0;
while prod > m {
// FIXME(#6050): overloaded operators force moves with generic types
// FIXME(#5992): assignment operator overloads
// d0 -= d_unit
d0 = d0 - d_unit;
// FIXME(#6050): overloaded operators force moves with generic types
// prod = prod - b_unit;
// FIXME(#5992): assignment operator overloads
// prod -= b_unit;
prod = prod - b_unit
}
if d0.is_zero() {
n = 2;
continue;
}
n = 1;
// FIXME(#6102): Assignment operator for BigInt causes ICE
// FIXME(#5992): assignment operator overloads
// d += d0;
d = d + d0;
// FIXME(#6102): Assignment operator for BigInt causes ICE
// FIXME(#5992): assignment operator overloads
// m -= prod;
m = m - prod;
}
Expand Down Expand Up @@ -724,8 +724,7 @@ impl BigUint {
let d: Option<BigUint> = FromPrimitive::from_uint(d);
match d {
Some(d) => {
// FIXME(#6102): Assignment operator for BigInt
// causes ICE:
// FIXME(#5992): assignment operator overloads
// n += d * power;
n = n + d * power;
}
Expand All @@ -738,7 +737,7 @@ impl BigUint {
return Some(n);
}
end -= unit_len;
// FIXME(#6050): overloaded operators force moves with generic types
// FIXME(#5992): assignment operator overloads
// power *= base_num;
power = power * base_num;
}
Expand Down Expand Up @@ -2068,7 +2067,7 @@ mod biguint_tests {
fn factor(n: uint) -> BigUint {
let mut f: BigUint = One::one();
for i in range(2, n + 1) {
// FIXME(#6102): Assignment operator for BigInt causes ICE
// FIXME(#5992): assignment operator overloads
// f *= FromPrimitive::from_uint(i);
f = f * FromPrimitive::from_uint(i).unwrap();
}
Expand Down
4 changes: 2 additions & 2 deletions src/libnum/rational.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,10 @@ impl<T: Clone + Integer + Ord>
fn reduce(&mut self) {
let g : T = self.numer.gcd(&self.denom);

// FIXME(#6050): overloaded operators force moves with generic types
// FIXME(#5992): assignment operator overloads
// self.numer /= g;
self.numer = self.numer / g;
// FIXME(#6050): overloaded operators force moves with generic types
// FIXME(#5992): assignment operator overloads
// self.denom /= g;
self.denom = self.denom / g;

Expand Down
2 changes: 1 addition & 1 deletion src/librustc/back/archive.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ impl<'a> Archive<'a> {
pub fn read(&self, file: &str) -> Vec<u8> {
// Apparently if "ar p" is used on windows, it generates a corrupt file
// which has bad headers and LLVM will immediately choke on it
if cfg!(windows) && cfg!(windows) { // FIXME(#10734) double-and
if cfg!(windows) {
let loc = TempDir::new("rsar").unwrap();
let archive = os::make_absolute(&self.dst);
run_ar(self.sess, "x", Some(loc.path()), [&archive,
Expand Down