rustdoc: prevent ctors from resolving #131224
Conversation
|
rustbot has assigned @GuillaumeGomez. Use |
rustbot
added
S-waiting-on-review
notriddle
force-pushed
the
notriddle/intra-doc-link-value
branch
from
20380b3 to
c52a0f8
Compare
This comment has been minimized.
This comment has been minimized.
notriddle
force-pushed
the
notriddle/intra-doc-link-value
branch
from
c52a0f8 to
af83c21
Compare
notriddle
changed the title
This comment has been minimized.
This comment has been minimized.
notriddle
force-pushed
the
notriddle/intra-doc-link-value
branch
from
af83c21 to
620bd3b
Compare
This comment has been minimized.
This comment has been minimized.
notriddle
force-pushed
the
notriddle/intra-doc-link-value
branch
from
620bd3b to
253fec4
Compare
|
Thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
| --> $DIR/disambiguator-mismatch.rs:93:14 | ||
| | | ||
| LL | /// Link to [field@S::A] | ||
| | ^^^^^^^^^^ this link resolved to a unit variant, which is not a field | ||
| | ^^^^^^^^^^ this link resolves to the variant `A`, which is not in the value namespace |
There was a problem hiding this comment.
this diagnostic change seems like a regression.
There was a problem hiding this comment.
Arf indeed. I was too happy about the fix and went too fast over this.
There was a problem hiding this comment.
To be clear, I went with an approach where rustdoc mostly pretends that ctors don't exist at all because:
- Having
struct@andvariant@check both the type and value ns's would've cause a perf regression. - Adding a
ctor@disambiguator would've been way too much feature for something that only matters if you do a globuseshadowing hack.
|
Finished benchmarking commit (267cf8d): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 1.5%, secondary 4.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 772.86s -> 771.923s (-0.12%) |
…error, r=GuillaumeGomez rustdoc: cleaner errors on disambiguator/namespace mismatches Resolves rust-lang#131224 (review) r? `@jyn514`
Rollup merge of rust-lang#131260 - notriddle:notriddle/disambiguator-error, r=GuillaumeGomez rustdoc: cleaner errors on disambiguator/namespace mismatches Resolves rust-lang#131224 (review) r? `@jyn514`
Fixes #130591