Handle librustdoc cases of rustc::potential_query_instability lint

[ismailarilik]

This PR removes #![allow(rustc::potential_query_instability)] line from src/librustdoc/lib.rs and converts FxHash{Map,Set} types into FxIndex{Map,Set} to suppress lint errors.

A somewhat tracking issue: #84447

r? @compiler-errors

[rustbot]

Some changes occurred in src/librustdoc/clean/types.rs

cc @camelid

[compiler-errors]

r? rustdoc

[ismailarilik]

@rustbot author

[notriddle]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 74187bd with merge bca6fc2...

[bors]

☀️ Try build successful - checks-actions
Build commit: bca6fc2 (bca6fc2c84a6ecbcf8d63babb0e606974a6d0692)

[rust-timer]

Finished benchmarking commit (bca6fc2): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.2%, 1.4%]	10
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.4%	[0.2%, 1.4%]	10

Max RSS (memory usage)

Results (primary 1.6%, secondary -0.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.6%	[1.6%, 1.6%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.7%	[-0.7%, -0.7%]	1
All ❌✅ (primary)	1.6%	[1.6%, 1.6%]	1

Cycles

Results (secondary 10.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	10.1%	[10.1%, 10.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 771.465s -> 770.582s (-0.11%)
Artifact size: 342.03 MiB -> 342.06 MiB (0.01%)

[notriddle]

@rustbot label: +perf-regression-triaged

1% regression in exchange for a reproducible build improvement. If we want to claw it back, we need to iterate over hash maps less.

[notriddle]

@bors r+

[bors]

📌 Commit 74187bd has been approved by notriddle

It is now in the queue for this repository.

[bors]

⌛ Testing commit 74187bd with merge e902b9a...

[bors]

💔 Test failed - checks-actions

[ismailarilik]

@rustbot author

[ismailarilik]

@rustbot review

[ismailarilik]

@notriddle I just made this change: https://github.com/rust-lang/rust/pull/131259/files#diff-e1cf7ef2fb411d24980cd4cbea1e867cc36029e9496e1ceca64cfb6a0e3510f6L81

[notriddle]

I see it.

@bors r+

[bors]

📌 Commit e0a20b4 has been approved by notriddle

It is now in the queue for this repository.

[bors]

⌛ Testing commit e0a20b4 with merge 373971a...

[bors]

☀️ Test successful - checks-actions
Approved by: notriddle
Pushing 373971a to master...

[rust-timer]

Finished benchmarking commit (373971a): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.2%, 1.4%]	9
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.5%	[-0.6%, -0.4%]	2
All ❌✅ (primary)	0.5%	[0.2%, 1.4%]	9

Max RSS (memory usage)

Results (primary -0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.5%	[2.5%, 2.5%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.7%	[-2.7%, -2.7%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.1%	[-2.7%, 2.5%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 773.26s -> 773.691s (0.06%)
Artifact size: 329.49 MiB -> 329.52 MiB (0.01%)

[lqd]

Similar results to pre-merge results, already triaged here.

1% regression in exchange for a reproducible build improvement. If we want to claw it back, we need to iterate over hash maps less.

@rustbot label: +perf-regression-triaged