Skip to content

Add myself to bootstrap review rotation #131497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2024
Merged

Add myself to bootstrap review rotation #131497

merged 1 commit into from
Oct 11, 2024

Conversation

@jieyouxu
Copy link
Member

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 10, 2024
@jieyouxu
Copy link
Member Author

Since the team PR is merged, this is good to go.

@jieyouxu jieyouxu marked this pull request as ready for review October 11, 2024 08:49
@rustbot
Copy link
Collaborator

rustbot commented Oct 11, 2024

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@onur-ozkan
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 11, 2024

📌 Commit 57ae34a has been approved by onur-ozkan

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 11, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 11, 2024
@bors
Auto merge of rust-lang#131497 - jieyouxu:spin, r=onur-ozkan
8e79591 
Add myself to bootstrap review rotation

r? `@onur-ozkan`
@bors
Copy link
Collaborator

bors commented Oct 11, 2024

⌛ Testing commit 57ae34a with merge 8e79591...

@jieyouxu
Copy link
Member Author

@bors r- retry (bors problem)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 11, 2024
@jieyouxu
Copy link
Member Author

@bors r=onur-ozkan rollup

@bors
Copy link
Collaborator

bors commented Oct 11, 2024

📌 Commit 57ae34a has been approved by onur-ozkan

It is now in the queue for this repository.

@matthiaskrgr matthiaskrgr mentioned this pull request Oct 11, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 11, 2024
@bors
Auto merge of rust-lang#131540 - matthiaskrgr:rollup-elbgu1w, r=matth…
484c8e7 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#131464 (Update wasm-component-ld to 0.5.10)
 - rust-lang#131476 (coverage: Include the highest counter ID seen in `.cov-map` dumps)
 - rust-lang#131497 (Add myself to bootstrap review rotation)
 - rust-lang#131498 (Consider outermost const-anon in `non_local_def` lint)
 - rust-lang#131512 (Fixing rustDoc for LayoutError.)
 - rust-lang#131529 (rustdoc-json-types: fix typo in comment)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0969882 into rust-lang:master Oct 11, 2024
6 of 7 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Oct 11, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 11, 2024
@rust-timer
Unrolled build for rust-lang#131497
eb8537d 
Rollup merge of rust-lang#131497 - jieyouxu:spin, r=onur-ozkan

Add myself to bootstrap review rotation

r? `@onur-ozkan`
@jieyouxu jieyouxu deleted the spin branch October 11, 2024 13:12
@tgross35 tgross35 mentioned this pull request Oct 11, 2024
Closed
@tgross35
Copy link
Contributor

@bors r- still in the queue

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@onur-ozkan onur-ozkan

Labels

A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

Projects

None yet

Milestone

1.83.0

Development

Successfully merging this pull request may close these issues.

5 participants

@jieyouxu @rustbot @onur-ozkan @bors @tgross35