Skip to content

Move polarity into PolyTraitRef rather than storing it on the side #131652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 15, 2024
Merged

Move polarity into PolyTraitRef rather than storing it on the side #131652

merged 2 commits into from
Oct 15, 2024

Conversation

compiler-errors
Copy link
Member

Arguably we could move these modifiers into TraitRef instead of PolyTraitRef, but I see TraitRef as simply the path part of the trait ref. It doesn't really matter -- refactoring this further is much easier now.

@rustbot
Copy link
Collaborator

rustbot commented Oct 13, 2024

r? @Nadrieril

rustbot has assigned @Nadrieril.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 13, 2024
@rustbot
Copy link
Collaborator

rustbot commented Oct 13, 2024

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

HIR ty lowering was modified

cc @fmease

@compiler-errors compiler-errors force-pushed the modifiers branch 2 times, most recently from 61b9dca to ad43c2e Compare October 13, 2024 14:11
@compiler-errors compiler-errors mentioned this pull request Oct 13, 2024
Merged
Nadrieril
Nadrieril approved these changes Oct 13, 2024
View reviewed changes
Copy link
Member

@Nadrieril Nadrieril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable and like a nice improvement! I lack all context particularly for the first commit though so I'll let someone more knowledgeable call this.

r? compiler

@rustbot rustbot assigned chenyukang and unassigned Nadrieril Oct 13, 2024
@chenyukang
Copy link
Member

r? compiler

@rustbot rustbot assigned jieyouxu and unassigned chenyukang Oct 14, 2024
jieyouxu
jieyouxu approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me as well. As to removing the hack, if no tests fail then I think we're good 🤷 You can r=Nadrieril and me after a rebase.

@jieyouxu
Copy link
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 14, 2024
@bors
Copy link
Collaborator

bors commented Oct 14, 2024

☔ The latest upstream changes (presumably #131662) made this pull request unmergeable. Please resolve the merge conflicts.

@compiler-errors
Copy link
Member Author

@bors r=Nadrieril,jieyouxu

@bors
Copy link
Collaborator

bors commented Oct 14, 2024

📌 Commit 95dba28 has been approved by Nadrieril,jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 14, 2024
@compiler-errors compiler-errors mentioned this pull request Oct 14, 2024
Merged
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 14, 2024
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 14, 2024
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 15, 2024
Merged
@bors bors merged commit 4d53a28 into rust-lang:master Oct 15, 2024
6 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

@Nadrieril Nadrieril Nadrieril approved these changes

Assignees

@jieyouxu jieyouxu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.84.0
Development

Successfully merging this pull request may close these issues.
6 participants
@compiler-errors @rustbot @chenyukang @jieyouxu @bors @Nadrieril