Dont ICE when computing coverage of synthetic async closure body #131802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Swatinem
approved these changes
Oct 16, 2024
Zalathar
reviewed
Oct 16, 2024
tests/coverage/async_closure.rs
Outdated
| @@ -0,0 +1,16 @@ | |||
| #![feature(coverage_attribute)] | |||
There was a problem hiding this comment.
Nit: #![feature(coverage_attribute)] isn't needed here, as there are no #[coverage(..)] attributes in the source.
|
Thanks. I don't know much about async closures (or feedable queries), but this looks like a reasonable workaround. Other than the nit, there's one thing missing: The new test needs to be blessed again with r=me when that's done. |
Zalathar
added
the
A-code-coverage
|
@rustbot author |
rustbot
added
S-waiting-on-author
Zalathar
force-pushed
the
fnonce-coverage
branch
from
2b22a19
to
cdbf28a
Compare
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 18, 2024
Rollup of 9 pull requests Successful merges: - rust-lang#130136 (Partially stabilize const_pin) - rust-lang#131755 (Regression test for AVR `rjmp` offset) - rust-lang#131774 (Add getentropy for RTEMS) - rust-lang#131802 (Dont ICE when computing coverage of synthetic async closure body) - rust-lang#131809 (Fix predicate signatures in retain_mut docs) - rust-lang#131858 (Remove outdated documentation for `repeat_n`) - rust-lang#131866 (Avoid use imports in `thread_local_inner!`) - rust-lang#131874 (Default to the medium code model on OpenHarmony LoongArch target) - rust-lang#131877 (checktools.sh: add link to issue for more context about disabled Miri tests) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 18, 2024
Rollup merge of rust-lang#131802 - compiler-errors:fnonce-coverage, r=Zalathar Dont ICE when computing coverage of synthetic async closure body I'm not totally certain if this is *right*, but at least it doesn't ICE. The issue is that we end up generating two MIR bodies for each async closure, since the `FnOnce` and `Fn`/`FnMut` implementations have different borrowing behavior of their captured variables. They should ideally both contribute to the coverage, since those MIR bodies are (*to the user*) the same code and should have no behavioral differences. This PR at least suppresses the ICEs, and then I guess worst case we can fix this the right way later. r? Zalathar or re-roll Fixes rust-lang#131190
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not totally certain if this is right, but at least it doesn't ICE.
The issue is that we end up generating two MIR bodies for each async closure, since the
FnOnceandFn/FnMutimplementations have different borrowing behavior of their captured variables. They should ideally both contribute to the coverage, since those MIR bodies are (to the user) the same code and should have no behavioral differences.This PR at least suppresses the ICEs, and then I guess worst case we can fix this the right way later.
r? Zalathar or re-roll
Fixes #131190