-
Notifications
You must be signed in to change notification settings - Fork 13.8k
manual fixes + editor syntax highlighting #13207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc @nikomatsakis @pcwalton @brson In particular I'm not sure about the style here. I've taken some liberties in what I think the language reference should look like. I think that, after I'm done implementing tbaa, I will spend some significant time wrangling with the manual. |
(starting with a grammar) |
#13215 also adds support in vim for the new attribute syntax. |
src/doc/rust.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no semi-colon
in the new attributes syntax. why you mention it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, bad edit, good catch.
Mostly around attributes and language items.
src/doc/rust.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure the terminating ;
on the EBNF rules is required.
r=me with my comments addressed. |
@cmr r=me after squash. |
- Sort attributes lexicographically - Use new attribute syntax consistently - Fix wording describing new attribute syntax - Expand section on `repr`
fix: add semicolon completion to mod fixes rust-lang#13196 `@Veykril` The tests are passing. I added one specifically for this case.
fixes rust-lang#12979 fixes rust-lang#12951 fixes rust-lang#13233 Tests still need to be finished and the docs still need to be updated, but this should otherwise ready. changelog: Lint `declare_interior_mutable_const` and `borrow_interior_mutable_const` more precisely
No description provided.