Rollup of 9 pull requests #132079

fmease · 2024-10-23T20:11:07Z

Successful merges:

Vectorized SliceContains #130991 (Vectorized SliceContains)
rustdoc: Document markdown module. #131928 (rustdoc: Document markdown module.)
Set signext or zeroext for integer arguments on RISC-V and LoongArch64 #131955 (Set signext or zeroext for integer arguments on RISC-V and LoongArch64)
Minor tweaks to compare_impl_item.rs #131979 (Minor tweaks to compare_impl_item.rs)
Add a test case for #131164 #132036 (Add a test case for non-pub function no longer compiled in debug profile, causing link errors on thumbv7em-none-eabihf with defmt #131164)
Specialize read_exact and read_buf_exact for VecDeque #132039 (Specialize read_exact and read_buf_exact for VecDeque)
"innermost", "outermost", "leftmost", and "rightmost" don't need hyphens #132060 ("innermost", "outermost", "leftmost", and "rightmost" don't need hyphens)
Clarify documentation of ptr::dangling() function #132065 (Clarify documentation of ptr::dangling() function)
Fix a typo in documentation of pointer::sub_ptr() #132066 (Fix a typo in documentation of pointer::sub_ptr())

r? @ghost
@rustbot modify labels: rollup

Rustdoc markdown handling is currently split between: - html::markdown, which contains all the meaty login - markdown, which is only used for when rustdoc renders a standalone markdown file Adds module-level doc-comment to markdown, and rename the function so it's clear that it's doing IO (instead of just rendering to a string).

These are all standard dictionary words and don't require hyphenation.

…r=Noratrieb Vectorized SliceContains Godbolt for the u32 case: https://rust.godbolt.org/z/exT9xYWGs Unsure about: - Should align_to be used? It didn't seem to matter in my benchmark but maybe I was lucky with alignment? - Should u8/i8 also be implemented? Currently uses memchr (SWAR) Some benchmarks on x86 (contains called on an array with no matches, worst case may be slightly worse): ## Large N ![large_n_contains](https://github.com/user-attachments/assets/5be79072-970b-44be-a56c-16dc677dee46) ## Small N ![small_n_contains](https://github.com/user-attachments/assets/b8a33790-c176-459f-84f4-05feee893cd0)

…, r=GuillaumeGomez rustdoc: Document `markdown` module. Rustdoc markdown handling is currently split between: - html::markdown, which contains all the meaty login - markdown, which is only used for when rustdoc renders a standalone markdown file Adds module-level doc-comment to markdown, and rename the function so it's clear that it's doing IO (instead of just rendering to a string).

…rkingjubilee Set `signext` or `zeroext` for integer arguments on RISC-V and LoongArch64 This PR contains 3 commits: - the first one introduces a new function `adjust_for_rust_abi` in `rustc_target`, and moves the x86 specific adjustment code into it; - the second one adds RISC-V specific adjustment code into it, which sets `signext` or `zeroext` attribute for integer arguments. - **UPDATE**: added the 3rd commit to apply the same adjustment for LoongArch64.

…l, r=fmease Minor tweaks to `compare_impl_item.rs` 1. Stop using the `InstantiatedPredicates` struct for `hybrid_preds` in `compare_impl_item.rs`, since we never actually push anything into the `spans` part of it. 2. Remove redundant impl args and don't do useless identity substitution, prefer calling `instantiate_identity`.

Add a test case for rust-lang#131164 The upstream has already been fixed, but it won't be backported to LLVM 19. r? jieyouxu or compiler try-job: x86_64-gnu-stable

…trieb Specialize `read_exact` and `read_buf_exact` for `VecDeque`

…r=jieyouxu "innermost", "outermost", "leftmost", and "rightmost" don't need hyphens These are all standard dictionary words and don't require hyphenation. ----- Encountered an instance of this in error messages and it bugged me, so I figured I'd fix it across the entire codebase.

Clarify documentation of `ptr::dangling()` function Also fixes the safety comment in `NonNull::dangling()` function. Fixes rust-lang#132004.

Fix a typo in documentation of `pointer::sub_ptr()` Just a typo in docs.

fmease · 2024-10-23T20:11:35Z

@bors r+ rollup=never p=6

bors · 2024-10-23T20:11:38Z

📌 Commit fbe33e3 has been approved by fmease

It is now in the queue for this repository.

bors · 2024-10-23T22:29:00Z

⌛ Testing commit fbe33e3 with merge b8bb296...

bors · 2024-10-24T01:21:12Z

☀️ Test successful - checks-actions
Approved by: fmease
Pushing b8bb296 to master...

rust-timer · 2024-10-24T01:23:42Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#130991	Vectorized SliceContains	`7fdddd1620c518f0aea96d33d780309cfa1aae16` (link)
#131928	rustdoc: Document `markdown` module.	`40b9346e5d6bcc96e3987b2cb621980d51016cc7` (link)
#131955	Set `signext` or `zeroext` for integer arguments on RISC-V …	`819ee57723acba7360f759d74a489125bbdeda1b` (link)
#131979	Minor tweaks to `compare_impl_item.rs`	`8283c3a19319ff5cab08b9f7eb44104b223760f3` (link)
#132036	Add a test case for #131164	`a213132b38ed3a7ca0f54101b70245d41e3d9084` (link)
#132039	Specialize `read_exact` and `read_buf_exact` for `VecDeque`	`50afd649eb057f47c672baa693f61d24bb40e7be` (link)
#132060	"innermost", "outermost", "leftmost", and "rightmost" don't…	`3902e16f871ef2d069109e560063de1f2a13b7e1` (link)
#132065	Clarify documentation of `ptr::dangling()` function	`35204f9cd6124e960c6554b6d93e8aaa0074a2b2` (link)
#132066	Fix a typo in documentation of `pointer::sub_ptr()`	`df9c5494e3fbf449d33c1bbcf58ed25e97fc94a8` (link)

previous master: 4f2f477fde

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2024-10-24T08:34:08Z

Finished benchmarking commit (b8bb296): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.3%, 0.3%]	1
Regressions ❌ (secondary)	0.1%	[0.1%, 0.1%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	[0.3%, 0.3%]	1

Max RSS (memory usage)

Results (primary 0.9%, secondary 0.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.6%	[0.4%, 2.8%]	3
Regressions ❌ (secondary)	3.1%	[2.3%, 3.9%]	2
Improvements ✅ (primary)	-1.1%	[-1.1%, -1.1%]	1
Improvements ✅ (secondary)	-0.5%	[-0.5%, -0.5%]	3
All ❌✅ (primary)	0.9%	[-1.1%, 2.8%]	4

Cycles

Results (primary 0.8%, secondary 0.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.8%	[0.6%, 1.2%]	11
Regressions ❌ (secondary)	0.7%	[0.7%, 0.7%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.8%	[0.6%, 1.2%]	11

Binary size

Results (primary 0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.1%, 0.5%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.2%	[-0.2%, -0.2%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[-0.2%, 0.5%]	6

Bootstrap: 781.235s -> 785.689s (0.57%)
Artifact size: 333.60 MiB -> 333.63 MiB (0.01%)

aDotInTheVoid and others added 21 commits October 19, 2024 13:37

tweak hybrid preds

73a37a1

Introduce adjust_for_rust_abi in rustc_target

03df13b

Set signext or zeroext for integer arguments on RISC-V

6b65524

Set signext or zeroext for integer arguments on LoongArch64

57bffe1

Specialize read_exact and read_buf_exact for VecDeque

77a7164

"innermost", "outermost", "leftmost", and "rightmost" don't need hyphens

ecdc244

These are all standard dictionary words and don't require hyphenation.

Add a test case for rust-lang#131164

6570a6f

fix documentation of ptr::dangling() function

f4c8ff3

fix a typo in documentation of pointer::sub_ptr()

b515bbf

More compare_impl_item simplifications

21d95fb

vectorized SliceContains

c11bfd8

Rollup merge of rust-lang#132036 - DianQK:test-131164, r=jieyouxu

f3d4887

Add a test case for rust-lang#131164 The upstream has already been fixed, but it won't be backported to LLVM 19. r? jieyouxu or compiler try-job: x86_64-gnu-stable

Rollup merge of rust-lang#132039 - a1phyr:vecdeque_read_exact, r=Nora…

28aacb3

…trieb Specialize `read_exact` and `read_buf_exact` for `VecDeque`

Rollup merge of rust-lang#132065 - tifv:dangling-docs, r=Noratrieb

b0a8e4e

Clarify documentation of `ptr::dangling()` function Also fixes the safety comment in `NonNull::dangling()` function. Fixes rust-lang#132004.

Rollup merge of rust-lang#132066 - tifv:ptr-docs-typo, r=Amanieu

fbe33e3

Fix a typo in documentation of `pointer::sub_ptr()` Just a typo in docs.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2024

fmease mentioned this pull request Oct 23, 2024

Rollup of 5 pull requests #132074

Closed

bors mentioned this pull request Oct 23, 2024

Rename Receiver -> LegacyReceiver #130225

Merged

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 24, 2024

bors merged commit b8bb296 into rust-lang:master Oct 24, 2024
7 checks passed

rustbot added this to the 1.84.0 milestone Oct 24, 2024

fmease deleted the rollup-agrd358 branch October 24, 2024 01:40

This was referenced Oct 24, 2024

Add Unicode block-drawing compiler output support #126597

Merged

rust_for_linux: -Zreg-struct-return commandline flag for X86 (#116973) #130777

Merged

TypingMode: merge intercrate, reveal, and defining_opaque_types #131856

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 9 pull requests #132079

Rollup of 9 pull requests #132079

fmease commented Oct 23, 2024

fmease commented Oct 23, 2024

bors commented Oct 23, 2024

bors commented Oct 23, 2024

bors commented Oct 24, 2024

rust-timer commented Oct 24, 2024

rust-timer commented Oct 24, 2024

Rollup of 9 pull requests #132079

Rollup of 9 pull requests #132079

Conversation

fmease commented Oct 23, 2024

fmease commented Oct 23, 2024

bors commented Oct 23, 2024

bors commented Oct 23, 2024

bors commented Oct 24, 2024

rust-timer commented Oct 24, 2024

rust-timer commented Oct 24, 2024

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size