-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[experiment] null-terminate track_caller strings #132081
Conversation
This comment has been minimized.
This comment has been minimized.
22e6ad4
to
4bd011f
Compare
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
…, r=<try> [experiment] null-terminate track_caller strings Trying to evaluate the compile-time/binary size impact of doing this. I suspect it's not measurable, but good to check. The implementation here is kind of bad. I tried doing two strategies at once and it went predictably. r? ghost
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (d6eee0b): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (primary -2.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResults (primary 0.0%, secondary 0.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 781.235s -> 780.531s (-0.09%) |
Trying to evaluate the compile-time/binary size impact of doing this. I suspect it's not measurable, but good to check.
The implementation here is kind of bad. I tried doing two strategies at once and it went predictably.
r? ghost