Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ~const item bounds #132118

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Oct 24, 2024

Supports the only missing capability of ~const associated types that I can think of now (this is obviously excluding ~const opaques, which I see as an extension to this; I'll probably do that next).

r? @lcnr mostly b/c it changes candidate assembly, or reassign

cc @fee1-dead

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Oct 24, 2024
Copy link
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after nit

surprisingly clean impl, was worried it would have ended up being more bothersome

@compiler-errors compiler-errors force-pushed the tilde-const-item-bounds branch 2 times, most recently from 29b76a0 to 7c02538 Compare October 24, 2024 23:36
@compiler-errors compiler-errors force-pushed the tilde-const-item-bounds branch from 7c02538 to 3bad501 Compare October 24, 2024 23:43
@compiler-errors
Copy link
Member Author

@bors r=lcnr rollup

@bors
Copy link
Collaborator

bors commented Oct 24, 2024

📌 Commit 3bad501 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 24, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 25, 2024
…kingjubilee

Rollup of 4 pull requests

Successful merges:

 - rust-lang#131457 (Expand `ptr::fn_addr_eq()` documentation.)
 - rust-lang#132085 (Update StableMIR doc to reflect current status)
 - rust-lang#132118 (Add support for `~const` item bounds)
 - rust-lang#132125 (coverage: Emit LLVM intrinsics using the normal helper method)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3c6d34f into rust-lang:master Oct 25, 2024
6 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Oct 25, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 25, 2024
Rollup merge of rust-lang#132118 - compiler-errors:tilde-const-item-bounds, r=lcnr

Add support for `~const` item bounds

Supports the only missing capability of `~const` associated types that I can think of now (this is obviously excluding `~const` opaques, which I see as an extension to this; I'll probably do that next).

r? ``@lcnr`` mostly b/c it changes candidate assembly, or reassign

cc ``@fee1-dead``
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants