-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ~const
item bounds
#132118
Merged
bors
merged 1 commit into
rust-lang:master
from
compiler-errors:tilde-const-item-bounds
Oct 25, 2024
Merged
Add support for ~const
item bounds
#132118
bors
merged 1 commit into
rust-lang:master
from
compiler-errors:tilde-const-item-bounds
Oct 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcnr
reviewed
Oct 24, 2024
lcnr
reviewed
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me after nit
surprisingly clean impl, was worried it would have ended up being more bothersome
29b76a0
to
7c02538
Compare
7c02538
to
3bad501
Compare
@bors r=lcnr rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 25, 2024
…kingjubilee Rollup of 4 pull requests Successful merges: - rust-lang#131457 (Expand `ptr::fn_addr_eq()` documentation.) - rust-lang#132085 (Update StableMIR doc to reflect current status) - rust-lang#132118 (Add support for `~const` item bounds) - rust-lang#132125 (coverage: Emit LLVM intrinsics using the normal helper method) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 25, 2024
Rollup merge of rust-lang#132118 - compiler-errors:tilde-const-item-bounds, r=lcnr Add support for `~const` item bounds Supports the only missing capability of `~const` associated types that I can think of now (this is obviously excluding `~const` opaques, which I see as an extension to this; I'll probably do that next). r? ``@lcnr`` mostly b/c it changes candidate assembly, or reassign cc ``@fee1-dead``
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
WG-trait-system-refactor
The Rustc Trait System Refactor Initiative (-Znext-solver)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports the only missing capability of
~const
associated types that I can think of now (this is obviously excluding~const
opaques, which I see as an extension to this; I'll probably do that next).r? @lcnr mostly b/c it changes candidate assembly, or reassign
cc @fee1-dead