Remove detail from label/note that is already available in other note #132157

estebank · 2024-10-25T21:30:13Z

Remove the "which is required by {root_obligation}" post-script in
"the trait X is not implemented for Y" explanation in E0277. This
information is already conveyed in the notes explaining requirements,
making it redundant while making the text (particularly in labels)
harder to read.

error[E0277]: the trait bound `NotCopy: Copy` is not satisfied
  --> $DIR/wf-static-type.rs:10:13
   |
LL | static FOO: IsCopy<Option<NotCopy>> = IsCopy { t: None };
   |             ^^^^^^^^^^^^^^^^^^^^^^^ the trait `Copy` is not implemented for `NotCopy`
   |
   = note: required for `Option<NotCopy>` to implement `Copy`
note: required by a bound in `IsCopy`
  --> $DIR/wf-static-type.rs:7:17
   |
LL | struct IsCopy<T:Copy> { t: T }
   |                 ^^^^ required by this bound in `IsCopy`

vs the prior

error[E0277]: the trait bound `NotCopy: Copy` is not satisfied
  --> $DIR/wf-static-type.rs:10:13
   |
LL | static FOO: IsCopy<Option<NotCopy>> = IsCopy { t: None };
   |             ^^^^^^^^^^^^^^^^^^^^^^^ the trait `Copy` is not implemented for `NotCopy`, which is required by `Option<NotCopy>: Copy`
   |
   = note: required for `Option<NotCopy>` to implement `Copy`
note: required by a bound in `IsCopy`
  --> $DIR/wf-static-type.rs:7:17
   |
LL | struct IsCopy<T:Copy> { t: T }
   |                 ^^^^ required by this bound in `IsCopy`

Ignore first three commits from #132086.

rustbot · 2024-10-25T21:30:22Z

r? @cjgillot

rustbot has assigned @cjgillot.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

jieyouxu

Thanks, I think this is indeed much clearer!

EDIT: I left a review comment on the wrong PR, lol.

compiler/rustc_trait_selection/src/error_reporting/traits/fulfillment_errors.rs

jieyouxu · 2024-10-28T05:28:46Z

Feel free to r=me after rebasing and reblessing the test once #132086 is merged.

Remove the "which is required by `{root_obligation}`" post-script in "the trait `X` is not implemented for `Y`" explanation in E0277. This information is already conveyed in the notes explaining requirements, making it redundant while making the text (particularly in labels) harder to read. ``` error[E0277]: the trait bound `NotCopy: Copy` is not satisfied --> $DIR/wf-static-type.rs:10:13 | LL | static FOO: IsCopy<Option<NotCopy>> = IsCopy { t: None }; | ^^^^^^^^^^^^^^^^^^^^^^^ the trait `Copy` is not implemented for `NotCopy` | = note: required for `Option<NotCopy>` to implement `Copy` note: required by a bound in `IsCopy` --> $DIR/wf-static-type.rs:7:17 | LL | struct IsCopy<T:Copy> { t: T } | ^^^^ required by this bound in `IsCopy` ``` vs the prior ``` error[E0277]: the trait bound `NotCopy: Copy` is not satisfied --> $DIR/wf-static-type.rs:10:13 | LL | static FOO: IsCopy<Option<NotCopy>> = IsCopy { t: None }; | ^^^^^^^^^^^^^^^^^^^^^^^ the trait `Copy` is not implemented for `NotCopy`, which is required by `Option<NotCopy>: Copy` | = note: required for `Option<NotCopy>` to implement `Copy` note: required by a bound in `IsCopy` --> $DIR/wf-static-type.rs:7:17 | LL | struct IsCopy<T:Copy> { t: T } | ^^^^ required by this bound in `IsCopy` ```

estebank · 2024-10-29T16:27:27Z

@bors r=jieyouxu

bors · 2024-10-29T16:27:30Z

📌 Commit 5b54286 has been approved by jieyouxu

It is now in the queue for this repository.

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#131984 (Stabilize if_let_rescope) - rust-lang#132151 (Ensure that resume arg outlives region bound for coroutines) - rust-lang#132157 (Remove detail from label/note that is already available in other note) - rust-lang#132274 (Cleanup op lookup in HIR typeck) - rust-lang#132319 (cg_llvm: Clean up FFI calls for setting module flags) - rust-lang#132321 (xous: sync: remove `rustc_const_stable` attribute on Condvar and Mutex new()) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#132157 - estebank:long-types-3, r=jieyouxu Remove detail from label/note that is already available in other note Remove the "which is required by `{root_obligation}`" post-script in "the trait `X` is not implemented for `Y`" explanation in E0277. This information is already conveyed in the notes explaining requirements, making it redundant while making the text (particularly in labels) harder to read. ``` error[E0277]: the trait bound `NotCopy: Copy` is not satisfied --> $DIR/wf-static-type.rs:10:13 | LL | static FOO: IsCopy<Option<NotCopy>> = IsCopy { t: None }; | ^^^^^^^^^^^^^^^^^^^^^^^ the trait `Copy` is not implemented for `NotCopy` | = note: required for `Option<NotCopy>` to implement `Copy` note: required by a bound in `IsCopy` --> $DIR/wf-static-type.rs:7:17 | LL | struct IsCopy<T:Copy> { t: T } | ^^^^ required by this bound in `IsCopy` ``` vs the prior ``` error[E0277]: the trait bound `NotCopy: Copy` is not satisfied --> $DIR/wf-static-type.rs:10:13 | LL | static FOO: IsCopy<Option<NotCopy>> = IsCopy { t: None }; | ^^^^^^^^^^^^^^^^^^^^^^^ the trait `Copy` is not implemented for `NotCopy`, which is required by `Option<NotCopy>: Copy` | = note: required for `Option<NotCopy>` to implement `Copy` note: required by a bound in `IsCopy` --> $DIR/wf-static-type.rs:7:17 | LL | struct IsCopy<T:Copy> { t: T } | ^^^^ required by this bound in `IsCopy` ``` *Ignore first three commits from rust-lang#132086

Changes required due to rust-lang/rust#132157 (Remove detail from label/note that is already available in other note). Resolves: model-checking#3659

Changes required due to rust-lang/rust#132157 (Remove detail from label/note that is already available in other note). Resolves: #3659 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

rustbot assigned cjgillot Oct 25, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Oct 25, 2024

estebank mentioned this pull request Oct 25, 2024

Tweak E0277 output when a candidate is available #132147

Merged

jieyouxu approved these changes Oct 26, 2024

View reviewed changes

compiler/rustc_trait_selection/src/error_reporting/traits/fulfillment_errors.rs Show resolved Hide resolved

compiler/rustc_trait_selection/src/error_reporting/traits/fulfillment_errors.rs Show resolved Hide resolved

jieyouxu assigned jieyouxu and unassigned cjgillot Oct 26, 2024

jieyouxu mentioned this pull request Oct 26, 2024

Tweak E0277 highlighting and "long type" path printing #132086

Merged

jieyouxu added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2024

estebank force-pushed the long-types-3 branch from 9562fd1 to 5b54286 Compare October 29, 2024 16:27

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 29, 2024

matthiaskrgr mentioned this pull request Oct 29, 2024

Rollup of 6 pull requests #132326

Merged

bors merged commit f9fdd63 into rust-lang:master Oct 29, 2024
6 checks passed

rustbot added this to the 1.84.0 milestone Oct 29, 2024

tautschnig mentioned this pull request Oct 30, 2024

Upgrade toolchain to 2024-10-30 model-checking/kani#3661

Merged

tautschnig added a commit to tautschnig/kani that referenced this pull request Oct 30, 2024

Upgrade toolchain to 2024-10-30

784435b

Changes required due to rust-lang/rust#132157 (Remove detail from label/note that is already available in other note). Resolves: model-checking#3659

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Remove detail from label/note that is already available in other note #132157

Remove detail from label/note that is already available in other note #132157

Uh oh!

estebank commented Oct 25, 2024 •

edited

Loading

Uh oh!

rustbot commented Oct 25, 2024

Uh oh!

jieyouxu left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

jieyouxu commented Oct 28, 2024

Uh oh!

estebank commented Oct 29, 2024

Uh oh!

bors commented Oct 29, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Remove detail from label/note that is already available in other note #132157

Remove detail from label/note that is already available in other note #132157

Uh oh!

Conversation

estebank commented Oct 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Oct 25, 2024

Uh oh!

jieyouxu left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jieyouxu commented Oct 28, 2024

Uh oh!

estebank commented Oct 29, 2024

Uh oh!

bors commented Oct 29, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

estebank commented Oct 25, 2024 •

edited

Loading

jieyouxu left a comment •

edited

Loading