docs: Correctly link riscv32e from platform-support.md #132205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @GuillaumeGomez. Use |
rustbot
added
the
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Oct 27, 2024
…-mislinked, r=tgross35 docs: Correctly link riscv32e from platform-support.md Correctly link the riscv32e platform support page. Just a mistake during the iteration of rust-lang#130555 that was missed in review. Presumably the rv32e-none and rv32i-none pages eventually should get merged, but this is a relatively recent addition to the ISA definition so it is not clear the current RISCV Embedded group has the expertise on-hand... nor did it have their consent.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 27, 2024
…kingjubilee Rollup of 5 pull requests Successful merges: - rust-lang#132123 (allow type-based search on foreign functions) - rust-lang#132170 (Add a Few Codegen Tests) - rust-lang#132183 (Fix code HTML items making big blocks if too long) - rust-lang#132192 (expand: Stop using artificial `ast::Item` for macros loaded from metadata) - rust-lang#132205 (docs: Correctly link riscv32e from platform-support.md) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 27, 2024
…kingjubilee Rollup of 4 pull requests Successful merges: - rust-lang#132123 (allow type-based search on foreign functions) - rust-lang#132183 (Fix code HTML items making big blocks if too long) - rust-lang#132192 (expand: Stop using artificial `ast::Item` for macros loaded from metadata) - rust-lang#132205 (docs: Correctly link riscv32e from platform-support.md) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 27, 2024
Rollup merge of rust-lang#132205 - workingjubilee:rv32e-platform-docs-mislinked, r=tgross35 docs: Correctly link riscv32e from platform-support.md Correctly link the riscv32e platform support page. Just a mistake during the iteration of rust-lang#130555 that was missed in review. Presumably the rv32e-none and rv32i-none pages eventually should get merged, but this is a relatively recent addition to the ISA definition so it is not clear the current RISCV Embedded group has the expertise on-hand... nor did it have their consent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly link the riscv32e platform support page.
Just a mistake during the iteration of #130555 that was missed in review. Presumably the rv32e-none and rv32i-none pages eventually should get merged, but this is a relatively recent addition to the ISA definition so it is not clear the current RISCV Embedded group has the expertise on-hand... nor did it have their consent.