Add GUI regression test for doc struct fields margins #132220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
I also realized that only union and struct fields have margin, not enum struct variants. Should I add margins for them as well? |
|
@bors r+ It might as well be its own PR. That way, this fix doesn't block it. |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 28, 2024
Rollup of 7 pull requests Successful merges: - rust-lang#131633 (error on alignments greater than `isize::MAX`) - rust-lang#132086 (Tweak E0277 highlighting and "long type" path printing) - rust-lang#132220 (Add GUI regression test for doc struct fields margins) - rust-lang#132225 (Dynamically link run-make support) - rust-lang#132227 (Pass constness with span into lower_poly_trait_ref) - rust-lang#132242 (Support `char::is_digit` in const contexts.) - rust-lang#132243 (Remove `ObligationCause::span()` method) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 28, 2024
Rollup merge of rust-lang#132220 - GuillaumeGomez:gui-test-struct-fields-margins, r=notriddle Add GUI regression test for doc struct fields margins Fixes rust-lang#131402. r? `@notriddle`
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Oct 28, 2024
…s-margins, r=notriddle [rustdoc] Unify variant struct fields margins with struct fields As discussed in rust-lang#132220. | before | after | |-|-| |  |  | r? `@notriddle`
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Oct 28, 2024
…s-margins, r=notriddle [rustdoc] Unify variant struct fields margins with struct fields As discussed in rust-lang#132220. | before | after | |-|-| |  |  | r? ``@notriddle``
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Oct 28, 2024
…s-margins, r=notriddle [rustdoc] Unify variant struct fields margins with struct fields As discussed in rust-lang#132220. | before | after | |-|-| |  |  | r? ```@notriddle```
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 29, 2024
…s-margins, r=notriddle [rustdoc] Unify variant struct fields margins with struct fields As discussed in rust-lang#132220. | before | after | |-|-| |  |  | r? ````@notriddle````
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Oct 29, 2024
…s-margins, r=notriddle [rustdoc] Unify variant struct fields margins with struct fields As discussed in rust-lang#132220. | before | after | |-|-| |  |  | r? `````@notriddle`````
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 29, 2024
Rollup merge of rust-lang#132258 - GuillaumeGomez:variant-structfields-margins, r=notriddle [rustdoc] Unify variant struct fields margins with struct fields As discussed in rust-lang#132220. | before | after | |-|-| |  |  | r? ```@notriddle```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #131402.
r? @notriddle