- 
                Notifications
    You must be signed in to change notification settings 
- Fork 13.9k
Remove dead code stemming from the old effects desugaring #132374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    f08a8e6    to
    a6bbdf0      
    Compare
  
    
              
                    compiler-errors
  
              
              approved these changes
              
                  
                    Oct 30, 2024 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very good
| @bors r+ rollup | 
    
  bors 
      added a commit
        to rust-lang-ci/rust
      that referenced
      this pull request
    
      Oct 31, 2024 
    
    
      
  
    
      
    
  
…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#132368 (Remove `do_not_const_check` from `Iterator` methods) - rust-lang#132373 (Make sure `type_param_predicates` resolves correctly for RPITIT) - rust-lang#132374 (Remove dead code stemming from the old effects desugaring) r? `@ghost` `@rustbot` modify labels: rollup
    
  rust-timer 
      added a commit
        to rust-lang-ci/rust
      that referenced
      this pull request
    
      Oct 31, 2024 
    
    
      
  
    
      
    
  
Rollup merge of rust-lang#132374 - fmease:rm-dead-eff-code, r=compiler-errors Remove dead code stemming from the old effects desugaring r? project-const-traits
    
  jhpratt 
      added a commit
        to jhpratt/rust
      that referenced
      this pull request
    
      Nov 26, 2024 
    
    
      
  
    
      
    
  
…iler-errors Remove dead code stemming from the old effects desugaring (II) Follow-up to rust-lang#132374. r? project-const-traits
    
  GuillaumeGomez 
      added a commit
        to GuillaumeGomez/rust
      that referenced
      this pull request
    
      Nov 26, 2024 
    
    
      
  
    
      
    
  
…iler-errors Remove dead code stemming from the old effects desugaring (II) Follow-up to rust-lang#132374. r? project-const-traits
    
  rust-timer 
      added a commit
        to rust-lang-ci/rust
      that referenced
      this pull request
    
      Nov 26, 2024 
    
    
      
  
    
      
    
  
Rollup merge of rust-lang#133443 - fmease:rm-dead-eff-code-ii, r=compiler-errors Remove dead code stemming from the old effects desugaring (II) Follow-up to rust-lang#132374. r? project-const-traits
    
  fmease 
      added a commit
        to fmease/rust
      that referenced
      this pull request
    
      Sep 1, 2025 
    
    
      
  
    
      
    
  
…1-dead Remove dead code stemming from an old effects desugaring CC rust-lang#132374, rust-lang#133443. r? fee1-dead
    
  jhpratt 
      added a commit
        to jhpratt/rust
      that referenced
      this pull request
    
      Sep 2, 2025 
    
    
      
  
    
      
    
  
…1-dead Remove dead code stemming from an old effects desugaring CC rust-lang#132374, rust-lang#133443. r? fee1-dead
    
  GuillaumeGomez 
      added a commit
        to GuillaumeGomez/rust
      that referenced
      this pull request
    
      Sep 2, 2025 
    
    
      
  
    
      
    
  
…1-dead Remove dead code stemming from an old effects desugaring CC rust-lang#132374, rust-lang#133443. r? fee1-dead
    
  rust-timer 
      added a commit
      that referenced
      this pull request
    
      Sep 2, 2025 
    
    
  
    
  rust-cloud-vms bot
      pushed a commit
        to makai410/rustc_public
      that referenced
      this pull request
    
      Oct 12, 2025 
    
    
      
  
    
      
    
  
Remove dead code stemming from an old effects desugaring CC rust-lang/rust#132374, rust-lang/rust#133443. r? fee1-dead
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    C-cleanup
  Category: PRs that clean code up or issues documenting cleanup. 
  
    S-waiting-on-bors
  Status: Waiting on bors to run and complete tests. Bors will change the label on completion. 
  
    T-compiler
  Relevant to the compiler team, which will review and decide on the PR/issue. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
r? project-const-traits