Skip to content

Conversation

fmease
Copy link
Member

@fmease fmease commented Oct 30, 2024

r? project-const-traits

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 30, 2024
@fmease fmease changed the title Remove dead code from the old effects desugaring Remove dead code stemming from the old effects desugaring Oct 30, 2024
@fmease fmease added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Oct 30, 2024
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good

@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 30, 2024

📌 Commit a6bbdf0 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 31, 2024
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#132368 (Remove `do_not_const_check` from `Iterator` methods)
 - rust-lang#132373 (Make sure `type_param_predicates` resolves correctly for RPITIT)
 - rust-lang#132374 (Remove dead code stemming from the old effects desugaring)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7d0dbc5 into rust-lang:master Oct 31, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 31, 2024
Rollup merge of rust-lang#132374 - fmease:rm-dead-eff-code, r=compiler-errors

Remove dead code stemming from the old effects desugaring

r? project-const-traits
@rustbot rustbot added this to the 1.84.0 milestone Oct 31, 2024
@fmease fmease deleted the rm-dead-eff-code branch October 31, 2024 03:55
jhpratt added a commit to jhpratt/rust that referenced this pull request Nov 26, 2024
…iler-errors

Remove dead code stemming from the old effects desugaring (II)

Follow-up to rust-lang#132374.
r? project-const-traits
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 26, 2024
…iler-errors

Remove dead code stemming from the old effects desugaring (II)

Follow-up to rust-lang#132374.
r? project-const-traits
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 26, 2024
Rollup merge of rust-lang#133443 - fmease:rm-dead-eff-code-ii, r=compiler-errors

Remove dead code stemming from the old effects desugaring (II)

Follow-up to rust-lang#132374.
r? project-const-traits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants