Fix #13247: get make check-stage1 working again
#13260
Conversation
1. Fix a long-standing typo in the makefile: the relevant CTEST_NAME here is `rpass-full` (with a dash), not `rpass_full`. 2. The rpass-full tests depend on the complete set of target libraries. Therefore, the rpass-full tests need to use the dependencies held in the CSREQ-prefixed variable, not the TLIBRUSTC_DEFAULT-prefixed variable.
|
Interesting, it appears that we're trying to run the The relevant block is here and I think that |
|
mrr I cannot tell if these android failures are injected by my change, I assume they must be... I guess I will have to try to figure out how to emulate the android build environment locally to try to reproduce. |
|
It looks like it's still trying to build lib{syntax,rustc} for android (which it shouldn't be doing), so I think the dependencies are still leaking in from somewhere. |
|
life is better when one can test one's patches. |
| @@ -604,7 +634,7 @@ $$(call TEST_OK_FILE,$(1),$(2),$(3),$(4)): \ | |||
| $$(TEST_SREQ$(1)_T_$(2)_H_$(3)) \ | |||
| $$(CTEST_DEPS_$(4)_$(1)-T-$(2)-H-$(3)) | |||
There was a problem hiding this comment.
Ah, another bug: when we disable running the tests, we should also drop these build prerequisites.
The problems I was hitting during the bors runs were failing during those attempts to resolve those prerequisites (and thus were masking another latent bug in the rule below: it is missing a close-paren).
First, documented the existing `CTEST_DISABLE_$(TEST_GROUP)` pattern for conditionally disabling tests based on missing host features. Added variant of above, `CTEST_DISABLE_NONSELFHOST_$(TEST_GROUP)`, which is only queried in contexts where the target is not on the CFG_HOST list (which I interpret as the list of targets that our host can compatibly emulate; e.g. the example that i686 and x86_64 can in theory run each others' tests). Driveby fix: Remove redundant copy of check-stage$(1)-T-$(2)-H-$(3)-$(4)-exec dependency declaration.
Fix #13247. r? @alexcrichton (or anyone else, really).
…e_items, r=llogiq Add new lint: `used_underscore_items` Closes rust-lang#13260 --- changelog: new [`used_underscore_items`] lint against using items with a single leading underscore
Fix #13247.
r? @alexcrichton (or anyone else, really).