Gate async fn trait bound modifier on `async_trait_bounds` #132612

compiler-errors · 2024-11-04T19:44:03Z

This PR moves async Fn() trait bounds into a new feature gate: feature(async_trait_bounds). The general vibe is that we will most likely stabilize the feature(async_closure) without the async Fn() trait bound modifier, so we need to gate that separately.

We're trying to work on the general vision of async trait bound modifier general in: rust-lang/rfcs#3710, however that RFC still needs more time for consensus to converge, and we've decided that the value that users get from calling the bound async Fn() is not really worth blocking landing async closures in general.

rustbot · 2024-11-25T01:59:29Z

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred in coverage tests.

cc @Zalathar

compiler-errors · 2024-11-25T01:59:41Z

r? compiler

tests/coverage/async_closure.rs

bors · 2024-12-01T10:46:02Z

☔ The latest upstream changes (presumably #133694) made this pull request unmergeable. Please resolve the merge conflicts.

lcnr · 2024-12-03T16:09:13Z

r? @lcnr

@bors r+ rollup

bors · 2024-12-03T16:09:17Z

📌 Commit 59e3e89 has been approved by lcnr

It is now in the queue for this repository.

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#132612 (Gate async fn trait bound modifier on `async_trait_bounds`) - rust-lang#133545 (Lint against Symbol::intern on a string literal) - rust-lang#133558 (Structurally resolve in `probe_adt`) - rust-lang#133696 (stabilize const_collections_with_hasher and build_hasher_default_const_new) - rust-lang#133753 (Reduce false positives on some common cases from if-let-rescope lint) - rust-lang#133762 (stabilize const_{size,align}_of_val) - rust-lang#133777 (document -Zrandomize-layout in the unstable book) - rust-lang#133779 (Use correct `hir_id` for array const arg infers) - rust-lang#133796 (Update the definition of `borrowing_sub`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#132612 - compiler-errors:async-trait-bounds, r=lcnr Gate async fn trait bound modifier on `async_trait_bounds` This PR moves `async Fn()` trait bounds into a new feature gate: `feature(async_trait_bounds)`. The general vibe is that we will most likely stabilize the `feature(async_closure)` *without* the `async Fn()` trait bound modifier, so we need to gate that separately. We're trying to work on the general vision of `async` trait bound modifier general in: rust-lang/rfcs#3710, however that RFC still needs more time for consensus to converge, and we've decided that the value that users get from calling the bound `async Fn()` is *not really* worth blocking landing async closures in general.

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 4, 2024

compiler-errors force-pushed the async-trait-bounds branch from 006acb0 to e25e8ea Compare November 6, 2024 18:06