-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gate async fn trait bound modifier on async_trait_bounds
#132612
Draft
compiler-errors
wants to merge
3
commits into
rust-lang:master
Choose a base branch
from
compiler-errors:async-trait-bounds
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Gate async fn trait bound modifier on async_trait_bounds
#132612
compiler-errors
wants to merge
3
commits into
rust-lang:master
from
compiler-errors:async-trait-bounds
+150
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Nov 4, 2024
compiler-errors
force-pushed
the
async-trait-bounds
branch
from
November 6, 2024 18:06
006acb0
to
e25e8ea
Compare
This comment has been minimized.
This comment has been minimized.
compiler-errors
force-pushed
the
async-trait-bounds
branch
from
November 6, 2024 18:51
e25e8ea
to
f9e8fb8
Compare
This comment has been minimized.
This comment has been minimized.
compiler-errors
force-pushed
the
async-trait-bounds
branch
from
November 6, 2024 19:42
f9e8fb8
to
830792e
Compare
This comment has been minimized.
This comment has been minimized.
compiler-errors
force-pushed
the
async-trait-bounds
branch
from
November 21, 2024 01:19
830792e
to
4b44076
Compare
This comment has been minimized.
This comment has been minimized.
compiler-errors
force-pushed
the
async-trait-bounds
branch
from
November 21, 2024 01:43
4b44076
to
62900d4
Compare
The job Click to see the possible cause of the failure (guessed by this bot)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
async Fn()
trait bounds into a new feature gate:feature(async_trait_bounds)
. The general vibe is that we will most likely stabilize thefeature(async_closure)
without theasync Fn()
trait bound modifier, so we need to gate that separately.We're trying to work on the general vision of
async
trait bound modifier general in: rust-lang/rfcs#3710, however that RFC still needs more time for consensus to converge, and we've decided that the value that users get from calling the boundasync Fn()
is not really worth blocking landing async closures in general.This is blocked on #132611, since moving these tests to
AsyncFn
is annoying without a prelude import.r? @ghost