Remove fixme comment about clobber_abi on PowerPC #132638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
jieyouxu
reviewed
Nov 5, 2024
Comment on lines
-1141
to
-1142
| // FIXME: PPC32 SysV ABI does not mention vector registers processing. | ||
| // https://refspecs.linuxfoundation.org/elf/elfspec_ppc.pdf |
There was a problem hiding this comment.
Suggestion: can you replace this with the link in the PR description? Can't hurt to have some useful links here :3 (unless this is already linked in the module)
There was a problem hiding this comment.
Added links (there are six links).
rust/compiler/rustc_target/src/asm/mod.rs
Lines 1131 to 1144 in e2d5031
There was a problem hiding this comment.
Yes, that's very nice, thank you!
taiki-e
force-pushed
the
ppc-asm-fixme
branch
from
2b4fe85 to
e2d5031
Compare
|
Thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 7, 2024
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#132638 (Remove fixme comment about clobber_abi on PowerPC) - rust-lang#132726 (Remove unused intercrate dependencies) - rust-lang#132729 (Make fn_abi_sanity_check a bit stricter) - rust-lang#132734 ( remove 'platform-intrinsic' ABI leftovers) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 7, 2024
Rollup merge of rust-lang#132638 - taiki-e:ppc-asm-fixme, r=jieyouxu Remove fixme comment about clobber_abi on PowerPC This was considered an unresolved question in rust-lang#131341, but according to the ABI document published in 2011 by Power.org the current implementation is fine as-is. rust-lang#131341 (comment) > According to [Power Architecture 32-bit Application Binary Interface Supplement 1.0 - Linux & Embedded](https://web.archive.org/web/20120608163804/https://www.power.org/resources/downloads/Power-Arch-32-bit-ABI-supp-1.0-Unified.pdf) published in 2011, PPC32 has the same convention here as PPC64. > > Therefore, we can just remove the FIXME comment here. r? workingjubilee
mati865
pushed a commit
to mati865/rust
that referenced
this pull request
Nov 12, 2024
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#132638 (Remove fixme comment about clobber_abi on PowerPC) - rust-lang#132726 (Remove unused intercrate dependencies) - rust-lang#132729 (Make fn_abi_sanity_check a bit stricter) - rust-lang#132734 ( remove 'platform-intrinsic' ABI leftovers) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was considered an unresolved question in #131341, but according to the ABI document published in 2011 by Power.org the current implementation is fine as-is.
#131341 (comment)
r? workingjubilee