Skip to content

Conversation

jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented Nov 5, 2024

Changes

  • Drop --test-args=clang from aarch64-gnu-debug so run-make tests that are //@ needs-force-clang-based-tests no longer only run if their test name contains clang (which is a very cool footgun).
  • Reorganize run-make-suport library slightly to accommodate a raw gcc invocation.
  • Fix tests/run-make/mte-ffi/rmake.rs to use gcc instead of a c compiler.

try-job: aarch64-gnu
try-job: aarch64-gnu-debug

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Nov 5, 2024
@jieyouxu jieyouxu marked this pull request as draft November 5, 2024 16:21
@jieyouxu

This comment was marked as outdated.

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 5, 2024
… r=<try>

Liberate `aarch64-gnu-debug` from the shackles of `--test-args=clang`

r? `@ghost`

try-job: aarch64-gnu-debug
@bors

This comment was marked as outdated.

@rust-log-analyzer

This comment has been minimized.

@bors

This comment was marked as outdated.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 5, 2024
@jieyouxu
Copy link
Member Author

jieyouxu commented Nov 7, 2024

tests/run-make/mte-ffi
output status: `signal: 11 (SIGSEGV) (core dumped)`
prctl() failed: Invalid argument

Huh.

@jieyouxu jieyouxu force-pushed the liberate-aarch64-gnu-debug branch from 2589239 to ce79835 Compare November 10, 2024 08:11
@rustbot rustbot added the A-run-make Area: port run-make Makefiles to rmake.rs label Nov 10, 2024
@jieyouxu
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 10, 2024
… r=<try>

Liberate `aarch64-gnu-debug` from the shackles of `--test-args=clang`

r? `@ghost`

try-job: aarch64-gnu
try-job: aarch64-gnu-debug
@bors
Copy link
Collaborator

bors commented Nov 10, 2024

⌛ Trying commit ce79835 with merge 5726f86...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented Nov 10, 2024

💔 Test failed - checks-actions

@jieyouxu jieyouxu force-pushed the liberate-aarch64-gnu-debug branch from ce79835 to ccb3d10 Compare November 12, 2024 08:29
@jieyouxu jieyouxu force-pushed the liberate-aarch64-gnu-debug branch from ccb3d10 to a6dac70 Compare November 12, 2024 09:05
@jieyouxu
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented Nov 12, 2024

⌛ Trying commit a6dac70 with merge a905c9c...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 12, 2024
… r=<try>

Liberate `aarch64-gnu-debug` from the shackles of `--test-args=clang`

r? `@ghost`

try-job: aarch64-gnu
try-job: aarch64-gnu-debug
@bors
Copy link
Collaborator

bors commented Nov 12, 2024

☀️ Try build successful - checks-actions
Build commit: a905c9c (a905c9cfe76e0551956549194fb35bcd8d587645)

@jieyouxu jieyouxu added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Nov 12, 2024
@jieyouxu jieyouxu marked this pull request as ready for review November 12, 2024 11:10
@jieyouxu

This comment was marked as outdated.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 12, 2024
@jieyouxu

This comment was marked as outdated.

@rustbot rustbot assigned fmease and unassigned TaKO8Ki Nov 12, 2024
@jieyouxu

This comment was marked as outdated.

@rustbot rustbot assigned pnkfelix and unassigned fmease Nov 13, 2024
@jieyouxu
Copy link
Member Author

Uh actually maybe r? @Kobzol (mostly trivial run-make test stuff + adjusting a CI job's flag tbh)

@rustbot rustbot assigned Kobzol and unassigned pnkfelix Nov 16, 2024
@Kobzol
Copy link
Member

Kobzol commented Nov 17, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 17, 2024

📌 Commit a6dac70 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 17, 2024
@bors
Copy link
Collaborator

bors commented Nov 17, 2024

⌛ Testing commit a6dac70 with merge 5ec7d6e...

@bors
Copy link
Collaborator

bors commented Nov 17, 2024

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing 5ec7d6e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 17, 2024
@bors bors merged commit 5ec7d6e into rust-lang:master Nov 17, 2024
7 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Nov 17, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (5ec7d6e): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.8% [-0.8%, -0.8%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary -1.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.5% [2.5%, 2.5%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.2% [-3.3%, -3.2%] 2
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 788.509s -> 789.328s (0.10%)
Artifact size: 335.54 MiB -> 335.47 MiB (-0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants