-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Liberate aarch64-gnu-debug
from the shackles of --test-args=clang
#132646
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
… r=<try> Liberate `aarch64-gnu-debug` from the shackles of `--test-args=clang` r? `@ghost` try-job: aarch64-gnu-debug
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
Huh. |
2589239
to
ce79835
Compare
@bors try |
… r=<try> Liberate `aarch64-gnu-debug` from the shackles of `--test-args=clang` r? `@ghost` try-job: aarch64-gnu try-job: aarch64-gnu-debug
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
…ang` And run all eligible run-make tests.
ce79835
to
ccb3d10
Compare
ccb3d10
to
a6dac70
Compare
@bors try |
… r=<try> Liberate `aarch64-gnu-debug` from the shackles of `--test-args=clang` r? `@ghost` try-job: aarch64-gnu try-job: aarch64-gnu-debug
☀️ Try build successful - checks-actions |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Uh actually maybe r? @Kobzol (mostly trivial run-make test stuff + adjusting a CI job's flag tbh) |
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (5ec7d6e): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (secondary -1.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 788.509s -> 789.328s (0.10%) |
Changes
--test-args=clang
fromaarch64-gnu-debug
so run-make tests that are//@ needs-force-clang-based-tests
no longer only run if their test name containsclang
(which is a very cool footgun).tests/run-make/mte-ffi/rmake.rs
to usegcc
instead of a c compiler.try-job: aarch64-gnu
try-job: aarch64-gnu-debug