Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coverage: Restrict empty-span expansion to only cover { and } #132675

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

coverage: Restrict empty-span expansion to only cover { and } #132675

wants to merge 4 commits into from
+312 −303

Commits on Nov 6, 2024

  1. coverage: Pass ExtractedHirInfo to make_source_region 

    This isn't strictly necessary, but makes it easier to distinguish `body_span`
from the specific `span` being processed.
    @Zalathar
    Zalathar committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    f380d23 View commit details
    Browse the repository at this point in the history

  2. coverage: Add GlobalFileId for stricter type-checking of file IDs 

    We already had a dedicated `LocalFileId` index type, but previously we used a
raw `u32` for global file IDs, because index types were harder to pass through
FFI.
    @Zalathar
    Zalathar committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    a920895 View commit details
    Browse the repository at this point in the history

  3. coverage: Remove unhelpful code for handling multiple files per function 

    Functions currently can't have mappings in multiple files, and if that ever
changes (e.g. to properly support expansion regions), this code will need to be
completely overhauled anyway.
    @Zalathar
    Zalathar committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    71db4c5 View commit details
    Browse the repository at this point in the history

  4. coverage: Restrict empty-span expansion to only cover { and }

    @Zalathar
    Zalathar committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    583e460 View commit details
    Browse the repository at this point in the history