[DRAFT] Generate CGUs in parallel.

[nnethercote]

r? @ghost

[nnethercote]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 2bb6fb5 with merge 2f9c955...

[rust-log-analyzer]

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

#16 3.004 Building wheels for collected packages: reuse
#16 3.005   Building wheel for reuse (pyproject.toml): started
#16 3.248   Building wheel for reuse (pyproject.toml): finished with status 'done'
#16 3.249   Created wheel for reuse: filename=reuse-4.0.3-cp310-cp310-manylinux_2_35_x86_64.whl size=132720 sha256=026f3bb0f1aa8090b861fd0a0939cb1a782396d84c8aab7875096557d637a0f6
#16 3.249   Stored in directory: /tmp/pip-ephem-wheel-cache-0wiurp3j/wheels/3d/8d/0a/e0fc6aba4494b28a967ab5eaf951c121d9c677958714e34532
#16 3.252 Installing collected packages: boolean-py, binaryornot, tomlkit, reuse, python-debian, markupsafe, license-expression, jinja2, chardet, attrs
#16 3.641 Successfully installed attrs-23.2.0 binaryornot-0.4.4 boolean-py-4.0 chardet-5.2.0 jinja2-3.1.4 license-expression-30.3.0 markupsafe-2.1.5 python-debian-0.1.49 reuse-4.0.3 tomlkit-0.13.0
#16 3.641 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#16 DONE 3.7s
---
    Checking rustc_borrowck v0.0.0 (/checkout/compiler/rustc_borrowck)
error: this boolean expression contains a logic bug
   --> compiler/rustc_codegen_ssa/src/base.rs:739:36
    |
739 |     let mut pre_compiled_cgus = if true || tcx.sess.threads() > 1 {
    |
help: this expression can be optimized out by applying boolean operations to the outer expression
   --> compiler/rustc_codegen_ssa/src/base.rs:739:44
    |
    |
739 |     let mut pre_compiled_cgus = if true || tcx.sess.threads() > 1 {
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#overly_complex_bool_expr
    = note: `-D clippy::overly-complex-bool-expr` implied by `-D clippy::correctness`
    = help: to override `-D clippy::correctness` add `#[allow(clippy::overly_complex_bool_expr)]`

[bors]

☀️ Try build successful - checks-actions
Build commit: 2f9c955 (2f9c95561799a74a32e056acdedb31c16ad48d33)

[rust-timer]

Finished benchmarking commit (2f9c955): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 20.1%, secondary 1.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	21.1%	[1.9%, 59.8%]	47
Regressions ❌ (secondary)	3.4%	[2.1%, 4.3%]	6
Improvements ✅ (primary)	-2.3%	[-2.3%, -2.3%]	2
Improvements ✅ (secondary)	-4.7%	[-6.7%, -2.6%]	2
All ❌✅ (primary)	20.1%	[-2.3%, 59.8%]	49

Cycles

Results (primary -1.4%, secondary -6.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.4%	[-2.3%, -0.9%]	29
Improvements ✅ (secondary)	-6.6%	[-7.9%, -2.1%]	7
All ❌✅ (primary)	-1.4%	[-2.3%, -0.9%]	29

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 781.244s -> 789.701s (1.08%)
Artifact size: 335.32 MiB -> 335.31 MiB (-0.00%)