Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: split x86_64-mingw job #132721

Draft
wants to merge 26 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
59f649f
CI: split x86_64-mingw job
MarcoIeni Nov 7, 2024
a3d3c42
Merge remote-tracking branch 'origin' into mingw-split
MarcoIeni Nov 14, 2024
4ad4a06
update isKnownToBeMingwBuild function
MarcoIeni Nov 15, 2024
02f4cbc
split test suite
MarcoIeni Nov 15, 2024
0d02d12
fix typo
MarcoIeni Nov 15, 2024
12c60ba
test free runner
MarcoIeni Nov 15, 2024
5aadf10
Merge remote-tracking branch 'origin' into mingw-split
MarcoIeni Nov 18, 2024
7abac96
download llvm
MarcoIeni Nov 18, 2024
e497da0
balance tests
MarcoIeni Nov 18, 2024
ad2db21
fix makefile
MarcoIeni Nov 18, 2024
0f176c8
change mingw regex
MarcoIeni Nov 18, 2024
8a95be3
Revert "download llvm"
MarcoIeni Nov 18, 2024
b35267b
switch mingw-1 job to free runners
MarcoIeni Nov 18, 2024
19b70e7
try fixing test split
MarcoIeni Nov 19, 2024
c2908fa
split using stage 2 tests only
MarcoIeni Nov 19, 2024
d06081f
rename tests
MarcoIeni Nov 19, 2024
904164b
Merge remote-tracking branch 'origin' into mingw-split
MarcoIeni Nov 20, 2024
e882301
select all tests under the `tests/` dir
MarcoIeni Nov 20, 2024
4b9587d
escape character in makefile
MarcoIeni Nov 20, 2024
986e651
fix makefile
MarcoIeni Nov 20, 2024
da46489
escape
MarcoIeni Nov 21, 2024
4134e77
Merge remote-tracking branch 'origin' into mingw-split
MarcoIeni Nov 21, 2024
af15021
simplify
MarcoIeni Nov 21, 2024
4193ff8
Merge remote-tracking branch 'origin' into mingw-split
MarcoIeni Nov 21, 2024
037bdb1
restore old test list for testing
MarcoIeni Nov 21, 2024
0a084e3
remove x for testing
MarcoIeni Nov 21, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/bootstrap/mk/Makefile.in
Original file line number Diff line number Diff line change
Expand Up @@ -108,11 +108,21 @@ ci-msvc: ci-msvc-py ci-msvc-ps1

## MingW native builders

# Set of tests that should represent half of the time of the test suite.
# Used to split tests across multiple CI runners.
TESTS_IN_MINGW_2 := \
tests/ui \
tests/rustdoc \
tests/run-make \
tests/rustdoc-ui \
tests/ui-fulldeps \
tests/rustdoc-json

# test both x and bootstrap entrypoints
ci-mingw-x:
$(Q)$(CFG_SRC_DIR)/x test --stage 2 tidy
$(Q)$(CFG_SRC_DIR)/x test --stage 2 $(TESTS_IN_MINGW_2)
ci-mingw-bootstrap:
$(Q)$(BOOTSTRAP) test --stage 2 --skip tidy
$(Q)$(BOOTSTRAP) test --stage 2 $(TESTS_IN_MINGW_2:%=--skip %)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this magic do? Prefix --skip before each line? We should probably wait for #132979 with this, btw.

Copy link
Member Author

@MarcoIeni MarcoIeni Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefix --skip before each line?

yes

Yeah, makes sense to wait. The best would be if they support regex. It would be nice to do tests/*.

ci-mingw: ci-mingw-x ci-mingw-bootstrap

.PHONY: dist
16 changes: 13 additions & 3 deletions src/ci/github-actions/jobs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -431,14 +431,24 @@ auto:
NO_DOWNLOAD_CI_LLVM: 1
<<: *job-windows-8c

- image: x86_64-mingw
# x86_64-mingw is split into two jobs to run tests in parallel.
- image: x86_64-mingw-1
env:
SCRIPT: make ci-mingw
SCRIPT: make ci-mingw-x
RUST_CONFIGURE_ARGS: --build=x86_64-pc-windows-gnu
# We are intentionally allowing an old toolchain on this builder (and that's
# incompatible with LLVM downloads today).
NO_DOWNLOAD_CI_LLVM: 1
<<: *job-windows-8c
<<: *job-windows

- image: x86_64-mingw-2
env:
SCRIPT: make ci-mingw-bootstrap
RUST_CONFIGURE_ARGS: --build=x86_64-pc-windows-gnu
# We are intentionally allowing an old toolchain on this builder (and that's
# incompatible with LLVM downloads today).
NO_DOWNLOAD_CI_LLVM: 1
<<: *job-windows

- image: dist-x86_64-msvc
env:
Expand Down
3 changes: 2 additions & 1 deletion src/ci/shared.sh
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ function isLinux {
}

function isKnownToBeMingwBuild {
isGitHubActions && [[ "${CI_JOB_NAME}" == *mingw ]]
# CI_JOB_NAME must end with "mingw" and optionally `-N` to be considered a MinGW build.
isGitHubActions && [[ "${CI_JOB_NAME}" =~ mingw(-[0-9]+)?$ ]]
}

function isCiBranch {
Expand Down
Loading