Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for #11881 #13276

Closed
wants to merge 1 commit into from
Closed

Add test for #11881 #13276

wants to merge 1 commit into from

Conversation

JustAPerson
Copy link
Contributor

This code has been copied from the original issue and updated for modern Rust APIs.

@@ -0,0 +1,60 @@
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's 2014! (not that it really matters - we rarely update these :P)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my lol. I was checking the other issue-*.rs files in src/test/ to see what the convention was, and I just copied and pasted the header.
Do you think I should git commit --amend with an updated date?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not really important, might as well though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(we're probably just going to end up updating them all to 2014 - there's really no reason to pretend they're individual works)

@alexcrichton
Copy link
Member

Could you add Closes #11881 to the commit message? That way the issue will be auto-closed when it gets merged.

Thanks for this!

Closes #11881.

This code has been copied from the original issue and updated for
modern Rust APIs.
@JustAPerson
Copy link
Contributor Author

@alexcrichton, sure thing.

Thank you both for the help. I look forward to contributing more to Rust!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants