Mention both release *and* edition breakage for never type lints #132978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WaffleLapkin
added
A-lints
rustbot
added
S-waiting-on-review
WaffleLapkin
force-pushed
the
very-semantic-change-kind
branch
from
0925c06 to
8cb3d5d
Compare
This comment has been minimized.
This comment has been minimized.
WaffleLapkin
force-pushed
the
very-semantic-change-kind
branch
from
8cb3d5d to
afc883f
Compare
|
I actually think that we should not be warning this in deps yet... warning this in deps is currently unactionable from the user perspective (except for possibly upgrading a crate version), and I think it may need additional approval from T-lang 🤔 |
WaffleLapkin
force-pushed
the
very-semantic-change-kind
branch
2 times, most recently
from
6d4aa37 to
de34288
Compare
|
@compiler-errors I've reverted the change making the lints reported in deps. |
|
ty :> |
compiler-errors
changed the title
| @@ -4185,7 +4185,7 @@ declare_lint! { | |||
| Warn, | |||
| "never type fallback affecting unsafe function calls", | |||
| @future_incompatible = FutureIncompatibleInfo { | |||
| reason: FutureIncompatibilityReason::FutureReleaseSemanticsChange, | |||
| reason: FutureIncompatibilityReason::EditionAndFutureReleaseError(Edition::Edition2024), | |||
There was a problem hiding this comment.
hm, do we want to maintain the fact that this is a semantics change? i think we kinda care
There was a problem hiding this comment.
whoops i forgot to finish my sentece -- we kinda care about this difference, right?
There was a problem hiding this comment.
Yes, we should maintain this fact. Oops ^^'
traviscross
changed the title
WaffleLapkin
force-pushed
the
very-semantic-change-kind
branch
from
de34288 to
5aa873b
Compare
This comment has been minimized.
This comment has been minimized.
...rather than a future error
WaffleLapkin
force-pushed
the
very-semantic-change-kind
branch
from
5aa873b to
673bb5e
Compare
compiler-errors
approved these changes
Nov 15, 2024
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 15, 2024
…kind, r=compiler-errors Mention both release *and* edition breakage for never type lints This PR makes ~~two changes~~ a change to the never type lints (`dependency_on_unit_never_type_fallback` and `never_type_fallback_flowing_into_unsafe`): 1. Change the wording of the note to mention that the breaking change will be made in an edition _and_ in a future release 2. ~~Make these warnings be reported in deps (hopefully the lints are matured enough)~~ r? `@compiler-errors` cc `@ehuss` closes rust-lang#132930
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 15, 2024
…kind, r=compiler-errors Mention both release *and* edition breakage for never type lints This PR makes ~~two changes~~ a change to the never type lints (`dependency_on_unit_never_type_fallback` and `never_type_fallback_flowing_into_unsafe`): 1. Change the wording of the note to mention that the breaking change will be made in an edition _and_ in a future release 2. ~~Make these warnings be reported in deps (hopefully the lints are matured enough)~~ r? `@compiler-errors` cc `@ehuss` closes rust-lang#132930
This was referenced Nov 15, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 15, 2024
…llaumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#132936 (For expr `return (_ = 42);` unused_paren lint should not be triggered) - rust-lang#132956 (Add visit_coroutine_kind to ast::Visitor) - rust-lang#132978 (Mention both release *and* edition breakage for never type lints) - rust-lang#133074 (make UI test OS-agnostic) - rust-lang#133080 (Fix span edition for 2024 RPIT coming from an external macro ) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 16, 2024
Rollup merge of rust-lang#132978 - WaffleLapkin:very-semantic-change-kind, r=compiler-errors Mention both release *and* edition breakage for never type lints This PR makes ~~two changes~~ a change to the never type lints (`dependency_on_unit_never_type_fallback` and `never_type_fallback_flowing_into_unsafe`): 1. Change the wording of the note to mention that the breaking change will be made in an edition _and_ in a future release 2. ~~Make these warnings be reported in deps (hopefully the lints are matured enough)~~ r? ``@compiler-errors`` cc ``@ehuss`` closes rust-lang#132930
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
two changesa change to the never type lints (dependency_on_unit_never_type_fallbackandnever_type_fallback_flowing_into_unsafe):Make these warnings be reported in deps (hopefully the lints are matured enough)r? @compiler-errors
cc @ehuss
closes #132930