-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check_consts: fix error requesting feature gate when that gate is not actually needed #132992
Conversation
Some changes occurred to the CTFE machinery cc @rust-lang/wg-const-eval |
@@ -1,6 +1,6 @@ | |||
//@ compile-flags: -Zforce-unstable-if-unmarked | |||
//@ edition: 2021 | |||
#![feature(const_async_blocks, rustc_attrs, rustc_private)] | |||
#![feature(const_async_blocks, rustc_attrs)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this PR, removing rustc_private
here would have completely changed the output. So the point of the PR is that even without rustc_private
, the output here is as before: suggesting rustc_const_stable_indirect
on the callee.
@bors r+ rollup |
☀️ Test successful - checks-actions |
Finished benchmarking commit (ce40196): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -5.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary -2.1%, secondary -1.8%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 786.926s -> 786.906s (-0.00%) |
When working on rust-lang/hashbrown#586 I noticed that the compiler asks for the
rustc_private
feature to be enabled if one forgets to setrustc_const_stable_indirect
on a function -- but enablingrustc_private
would not actually help. This fixes the diagnostics.r? @compiler-errors