Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Visitor::visit_precise_capturing_arg so it returns a Visitor::Result #133049

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

maxcabrajac
Copy link
Contributor

@maxcabrajac maxcabrajac commented Nov 14, 2024

r? @petrochenkov

related to #128974 & #127615

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 14, 2024
@compiler-errors
Copy link
Member

r? compiler-errors @bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 15, 2024

📌 Commit 9fde49b has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 15, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 15, 2024
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#132817 (Recurse into APITs in `impl_trait_overcaptures`)
 - rust-lang#133021 (Refactor `configure_annotatable`)
 - rust-lang#133045 (tests: Test pac-ret flag merging on clang with LTO)
 - rust-lang#133049 (Change Visitor::visit_precise_capturing_arg so it returns a Visitor::Result)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a111716 into rust-lang:master Nov 15, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 15, 2024
Rollup merge of rust-lang#133049 - maxcabrajac:visit_precise_capturing_arg, r=compiler-errors

Change Visitor::visit_precise_capturing_arg so it returns a Visitor::Result

r? `@petrochenkov`

related to rust-lang#128974
@rustbot rustbot added this to the 1.84.0 milestone Nov 15, 2024
@workingjubilee
Copy link
Member

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 16, 2024
@maxcabrajac
Copy link
Contributor Author

Did this break something?

@compiler-errors
Copy link
Member

No, it just wasn't auto-closed by bors

@maxcabrajac
Copy link
Contributor Author

Ah now I get it! After getting merged, this still showed up in queue and messed things up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants