Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use download-rustc=false global default, if-unchanged for tools and library profiles, and make rust.debug-assertions=true inhibit downloading CI rustc #133068

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use download-rustc=false global default, if-unchanged for tools and library profiles, and make rust.debug-assertions=true inhibit downloading CI rustc #133068

wants to merge 3 commits into from
+74 −13

Commits on Nov 21, 2024

  1. Revert global default for download-rustc to false 

    And only use `download-rustc = "if-unchanged"` for the `library` and
`tools` profile defaults.
    @jieyouxu
    jieyouxu committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    da09d24 View commit details
    Browse the repository at this point in the history

  2. Skip downloading CI rustc if rust.debug-assertions = true 

    Warn if `download-rustc` used with `rust.debug-assertions` as alt rustc
builds currently do not have rustc debug assertions enabled.
    @jieyouxu
    jieyouxu committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    5563bf5 View commit details
    Browse the repository at this point in the history

  3. CI: don't force CI rustc for x86_64-gnu-tools 

    CI alt rustc builds do not have rustc debug assertions currently.
    @jieyouxu
    jieyouxu committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    46ba361 View commit details
    Browse the repository at this point in the history