Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: split x86_64-msvc-ext job #133248

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MarcoIeni
Copy link
Member

@MarcoIeni MarcoIeni commented Nov 20, 2024

I'm splitting this job into two so that we can use free runners instead of large runners.

try-job: x86_64-msvc-ext
try-job: x86_64-msvc-ext3

@rustbot
Copy link
Collaborator

rustbot commented Nov 20, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Nov 20, 2024
@MarcoIeni
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 20, 2024
CI: use free runner in x86_64-msvc-ext

try-job: x86_64-msvc-ext
@bors
Copy link
Contributor

bors commented Nov 20, 2024

⌛ Trying commit 72ec288 with merge 8ad199b...

@bors
Copy link
Contributor

bors commented Nov 20, 2024

☀️ Try build successful - checks-actions
Build commit: 8ad199b (8ad199b7aeebfb192b2783e893dc21a0d5af88a3)

@MarcoIeni
Copy link
Member Author

trying again to check if there are cache misses somewhere.

@MarcoIeni
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 20, 2024
CI: use free runner in x86_64-msvc-ext

try-job: x86_64-msvc-ext
@bors
Copy link
Contributor

bors commented Nov 20, 2024

⌛ Trying commit 72ec288 with merge 943ae67e679e84b9a5e8c398662783e1cefcba29...

@bors
Copy link
Contributor

bors commented Nov 20, 2024

☀️ Try build successful - checks-actions
Build commit: 943ae67 (943ae67e679e84b9a5e8c398662783e1cefcba29)

@ChrisDenton
Copy link
Member

Oh btw I would like to rejoin it with msvc-ext2. Splitting them was only intended to be a temporary hack. If we do want them split long term then there's hopefully a more principled way to do it.

@MarcoIeni
Copy link
Member Author

We're trying to remove work from large runners, so I would prefer not joining the two jobs.
For example, I'm trying to split another job as well in #132721

If we do want them split long term then there's hopefully a more principled way to do it.

Yes, hopefully, I don't have a good solution. There's some discussion in zulip.

I asked the bootstrap team to hopefully find a better solution. I'm open to suggestions.

@MarcoIeni
Copy link
Member Author

MarcoIeni commented Nov 21, 2024

I have a question Chris, I see that the following env variables are different:

      HOST_TARGET: x86_64-pc-windows-msvc
      RUST_CONFIGURE_ARGS: --build=x86_64-pc-windows-msvc --enable-lld --save-toolstates=/tmp/toolstate/toolstates.json
      DEPLOY_TOOLSTATES_JSON: toolstates-windows.json

should the second job have the same env variables as the first one? If not, why?

@MarcoIeni
Copy link
Member Author

For the reviewer of this PR: I tried splitting the job because it took too long: 2h 52m

So I introduced a third job. Let's see how it goes!

@MarcoIeni
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Nov 21, 2024

⌛ Trying commit 395a386 with merge ee813ac...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 21, 2024
CI: use free runner in x86_64-msvc-ext

try-job: x86_64-msvc-ext
try-job: x86_64-msvc-ext3
@bors
Copy link
Contributor

bors commented Nov 21, 2024

☀️ Try build successful - checks-actions
Build commit: ee813ac (ee813acbc208f312e5f18899fb6b5af67e31d3b5)

@MarcoIeni
Copy link
Member Author

Nice, the timings look reasonable!
image

@MarcoIeni MarcoIeni changed the title CI: use free runner in x86_64-msvc-ext CI: split x86_64-msvc-ext job Nov 21, 2024
@MarcoIeni MarcoIeni marked this pull request as ready for review November 21, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants