-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: split x86_64-msvc-ext job #133248
base: master
Are you sure you want to change the base?
CI: split x86_64-msvc-ext job #133248
Conversation
rustbot has assigned @Mark-Simulacrum. Use |
@bors try |
CI: use free runner in x86_64-msvc-ext try-job: x86_64-msvc-ext
☀️ Try build successful - checks-actions |
trying again to check if there are cache misses somewhere. |
@bors try |
CI: use free runner in x86_64-msvc-ext try-job: x86_64-msvc-ext
⌛ Trying commit 72ec288 with merge 943ae67e679e84b9a5e8c398662783e1cefcba29... |
☀️ Try build successful - checks-actions |
Oh btw I would like to rejoin it with msvc-ext2. Splitting them was only intended to be a temporary hack. If we do want them split long term then there's hopefully a more principled way to do it. |
We're trying to remove work from large runners, so I would prefer not joining the two jobs.
Yes, hopefully, I don't have a good solution. There's some discussion in zulip. I asked the bootstrap team to hopefully find a better solution. I'm open to suggestions. |
I have a question Chris, I see that the following env variables are different:
should the second job have the same env variables as the first one? If not, why? |
For the reviewer of this PR: I tried splitting the job because it took too long: 2h 52m So I introduced a third job. Let's see how it goes! |
@bors try |
CI: use free runner in x86_64-msvc-ext try-job: x86_64-msvc-ext try-job: x86_64-msvc-ext3
☀️ Try build successful - checks-actions |
395a386
to
da94a89
Compare
I'm splitting this job into two so that we can use free runners instead of large runners.
try-job: x86_64-msvc-ext
try-job: x86_64-msvc-ext3