Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy bitcode for iOS #133297

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove legacy bitcode for iOS #133297

wants to merge 2 commits into from
+8 −35

Conversation

DianQK
Copy link
Member

@DianQK DianQK commented Nov 21, 2024

Follow #117364.

@rustbot
Copy link
Collaborator

rustbot commented Nov 21, 2024

r? @fmease

rustbot has assigned @fmease.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 21, 2024
@rustbot
Copy link
Collaborator

rustbot commented Nov 21, 2024

These commits modify compiler targets.
(See the Target Tier Policy.)

DianQK
DianQK commented Nov 21, 2024
View reviewed changes
compiler/rustc_target/src/spec/mod.rs
@@ -3412,7 +3409,6 @@ impl Target {
key!(main_needs_argc_argv, bool);
key!(has_thread_local, bool);
key!(obj_is_bitcode, bool);
key!(forces_embed_bitcode, bool);
key!(bitcode_llvm_cmdline);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LLVM still leave some code related to llvmcmd, but I believe this will also be removed in the future.

@rustbot
Copy link
Collaborator

rustbot commented Nov 21, 2024

These commits modify compiler targets.
(See the Target Tier Policy.)

@nikic
Copy link
Contributor

nikic commented Nov 24, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Nov 24, 2024

📌 Commit 7cc5fee has been approved by nikic

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 24, 2024
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Nov 24, 2024
@jieyouxu
Rollup merge of rust-lang#133297 - DianQK:embed-bitcode-ios, r=nikic
8d20d71 
Remove legacy bitcode for iOS

Follow rust-lang#117364.
@jieyouxu jieyouxu mentioned this pull request Nov 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn3 bjorn3 bjorn3 left review comments

Assignees

@fmease fmease

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DianQK @rustbot @nikic @bors @bjorn3 @fmease